Skip to content

[Merged by Bors] - feat(RingTheory): NNRat is ring of fractions of Nat#29388

Closed
wwylele wants to merge 1 commit intoleanprover-community:masterfrom
wwylele:nat-localize
Closed

[Merged by Bors] - feat(RingTheory): NNRat is ring of fractions of Nat#29388
wwylele wants to merge 1 commit intoleanprover-community:masterfrom
wwylele:nat-localize

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Sep 6, 2025 •
edited
Loading

Extract from the new revision of #29275.

Open in Gitpod

@github-actions github-actions bot added the t-ring-theory Ring theory label Sep 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 6, 2025 •
edited
Loading

PR summary 5197d2766d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ NNRat.isFractionRing

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

eric-wieser
eric-wieser reviewed Sep 6, 2025
View reviewed changes
@eric-wieser
Copy link
Copy Markdown
Member

eric-wieser commented Sep 6, 2025

except that currently IsFractionRing requires CommRing instead of CommSemiring

I think it's worth mentioning this in the comment on the instance.

@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 6, 2025
@wwylele wwylele removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 6, 2025
@wwylele wwylele requested a review from eric-wieser September 7, 2025 14:21
@wwylele wwylele mentioned this pull request Sep 7, 2025
Closed
3 tasks
@YaelDillies
Copy link
Copy Markdown
Contributor

YaelDillies commented Sep 9, 2025

I tried generalizing IsFractionRing but it looks like the refactoring of related lemma isn't trivial, and I am not sure if it is mathematically correct to do so.

What could possibly go wrong? It is merely an abbrev.

@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Sep 10, 2025

Alright, I generalized the definition of IsFractionRing to CommSemiring, and restated the instance in term of it. I left all other lemmas in the file unchanged as I am not super familiar with this topic, and left a comment calling for generalization

@wwylele wwylele changed the title feat(RingTheory): NNRat is localization of Nat feat(RingTheory): NNRat is ring of fractions of Nat Sep 11, 2025
YaelDillies
YaelDillies approved these changes Sep 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 11, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 11, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Sep 11, 2025

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Sep 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Sep 11, 2025
@wwylele
feat(RingTheory): NNRat is ring of fractions of Nat (#29388)
b26156e 
Extract from the new revision of #29275.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory): NNRat is ring of fractions of Nat [Merged by Bors] - feat(RingTheory): NNRat is ring of fractions of Nat Sep 11, 2025
@mathlib-bors mathlib-bors bot closed this Sep 11, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
@wwylele @joelriou
feat(RingTheory): NNRat is ring of fractions of Nat (leanprover-commu…
72d807b 
…nity#29388)

Extract from the new revision of leanprover-community#29275.
zhuyizheng pushed a commit to zhuyizheng/mathlib4 that referenced this pull request Oct 2, 2025
@wwylele @zhuyizheng
feat(RingTheory): NNRat is ring of fractions of Nat (leanprover-commu…
7f1f4da 
…nity#29388)

Extract from the new revision of leanprover-community#29275.
@wwylele wwylele deleted the nat-localize branch November 20, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wwylele @eric-wieser @YaelDillies @riccardobrasca