Skip to content

[Merged by Bors] - feat(Algebra/Order): Generalize IsMulTorsionFree to linearly ordered monoid#29386

Closed
wwylele wants to merge 1 commit intoleanprover-community:masterfrom
wwylele:monoid-torsion-free
Closed

[Merged by Bors] - feat(Algebra/Order): Generalize IsMulTorsionFree to linearly ordered monoid#29386
wwylele wants to merge 1 commit intoleanprover-community:masterfrom
wwylele:monoid-torsion-free

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Sep 6, 2025

Signature change:

-instance {α : Type*} [CommGroup α] [LinearOrder α] [IsOrderedMonoid α] : IsMulTorsionFree α
+instance {α : Type*} [Monoid α] [LinearOrder α] [MulLeftStrictMono α] [MulRightStrictMono α] : IsMulTorsionFree α

Open in Gitpod

@wwylele wwylele changed the title feat(Algebra/Order): Generalize IsMultTorsionFree to linearly ordered monoid feat(Algebra/Order): Generalize IsMulTorsionFree to linearly ordered monoid Sep 6, 2025
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Sep 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 6, 2025

PR summary 737db8d198

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance [MulLeftStrictMono M] [MulRightStrictMono M] : IsMulTorsionFree M
- instance : IsMulTorsionFree α where pow_left_injective _ hn := (pow_left_strictMono hn).injective

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 9, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 9, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Sep 9, 2025
mathlib-bors bot pushed a commit that referenced this pull request Sep 9, 2025
…monoid (#29386)

Signature change:
```diff
-instance {α : Type*} [CommGroup α] [LinearOrder α] [IsOrderedMonoid α] : IsMulTorsionFree α
+instance {α : Type*} [Monoid α] [LinearOrder α] [MulLeftStrictMono α] [MulRightStrictMono α] : IsMulTorsionFree α
```
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 9, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Order): Generalize IsMulTorsionFree to linearly ordered monoid [Merged by Bors] - feat(Algebra/Order): Generalize IsMulTorsionFree to linearly ordered monoid Sep 9, 2025
@mathlib-bors mathlib-bors bot closed this Sep 9, 2025
@wwylele wwylele deleted the monoid-torsion-free branch September 9, 2025 20:43
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
…monoid (leanprover-community#29386)

Signature change:
```diff
-instance {α : Type*} [CommGroup α] [LinearOrder α] [IsOrderedMonoid α] : IsMulTorsionFree α
+instance {α : Type*} [Monoid α] [LinearOrder α] [MulLeftStrictMono α] [MulRightStrictMono α] : IsMulTorsionFree α
```
robertmaxton42 pushed a commit to robertmaxton42/mathlib4 that referenced this pull request Sep 11, 2025
…monoid (leanprover-community#29386)

Signature change:
```diff
-instance {α : Type*} [CommGroup α] [LinearOrder α] [IsOrderedMonoid α] : IsMulTorsionFree α
+instance {α : Type*} [Monoid α] [LinearOrder α] [MulLeftStrictMono α] [MulRightStrictMono α] : IsMulTorsionFree α
```
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
…monoid (leanprover-community#29386)

Signature change:
```diff
-instance {α : Type*} [CommGroup α] [LinearOrder α] [IsOrderedMonoid α] : IsMulTorsionFree α
+instance {α : Type*} [Monoid α] [LinearOrder α] [MulLeftStrictMono α] [MulRightStrictMono α] : IsMulTorsionFree α
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants