[Merged by Bors] - chore: add deprecated modules#29209
Closed
adomani wants to merge 4 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: add deprecated modules#29209adomani wants to merge 4 commits intoleanprover-community:masterfrom
adomani wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
PR summary 8acd6dfb9e
|
| Files | Import difference |
|---|---|
Mathlib.Data.Complex.Exponential (new file) |
1304 |
Mathlib.Data.Complex.Trigonometric (new file) |
1305 |
Mathlib.Data.Real.Hyperreal (new file) |
1444 |
Mathlib.Data.Real.Cardinality (new file) |
1451 |
Mathlib.Data.Complex.ExponentialBounds (new file) |
1884 |
Mathlib.Data.Real.Pi.Bounds (new file) |
1958 |
Mathlib.Data.Real.Pi.Wallis (new file) |
2389 |
Mathlib.Data.Real.Pi.Leibniz (new file) |
2395 |
Mathlib.Data.Real.Pi.Irrational (new file) |
2399 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
Thank you for doing this! Would you like to also do #28909 and the moving of |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
Author
|
I added also the deprecations from #28909. This actually uncovered a bug in the process: if a directory no longer exist, the old script would fail. I fixed this now. |
Contributor
|
Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
These modules were renamed in #28948 and #28909, and this is semi-autogenerated PR to deprecate the old module names. These are 9 `Data.{Complex, Real}.xxx` files that have been renamed to `Analysis.{Complex, Real}.xxx`. I had forgotten about running `lake exe mk_all` after the deprecated modules had been generated.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
CBirkbeck
pushed a commit
to CBirkbeck/mathlib4
that referenced
this pull request
Sep 8, 2025
These modules were renamed in leanprover-community#28948 and leanprover-community#28909, and this is semi-autogenerated PR to deprecate the old module names. These are 9 `Data.{Complex, Real}.xxx` files that have been renamed to `Analysis.{Complex, Real}.xxx`. I had forgotten about running `lake exe mk_all` after the deprecated modules had been generated.
yuanyi-350
pushed a commit
to yuanyi-350/yuanyi_mathlib4
that referenced
this pull request
Sep 10, 2025
These modules were renamed in leanprover-community#28948 and leanprover-community#28909, and this is semi-autogenerated PR to deprecate the old module names. These are 9 `Data.{Complex, Real}.xxx` files that have been renamed to `Analysis.{Complex, Real}.xxx`. I had forgotten about running `lake exe mk_all` after the deprecated modules had been generated.
robertmaxton42
pushed a commit
to robertmaxton42/mathlib4
that referenced
this pull request
Sep 11, 2025
These modules were renamed in leanprover-community#28948 and leanprover-community#28909, and this is semi-autogenerated PR to deprecate the old module names. These are 9 `Data.{Complex, Real}.xxx` files that have been renamed to `Analysis.{Complex, Real}.xxx`. I had forgotten about running `lake exe mk_all` after the deprecated modules had been generated.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 17, 2025
Update references of `Data.Real.Pi.*` modules to `Analysis.Real.Pi.*` since they were marked deprecated in #29209.
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Oct 2, 2025
These modules were renamed in leanprover-community#28948 and leanprover-community#28909, and this is semi-autogenerated PR to deprecate the old module names. These are 9 `Data.{Complex, Real}.xxx` files that have been renamed to `Analysis.{Complex, Real}.xxx`. I had forgotten about running `lake exe mk_all` after the deprecated modules had been generated.
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Oct 2, 2025
…mmunity#29653) Update references of `Data.Real.Pi.*` modules to `Analysis.Real.Pi.*` since they were marked deprecated in leanprover-community#29209.
zhuyizheng
pushed a commit
to zhuyizheng/mathlib4
that referenced
this pull request
Oct 2, 2025
…mmunity#29653) Update references of `Data.Real.Pi.*` modules to `Analysis.Real.Pi.*` since they were marked deprecated in leanprover-community#29209.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These modules were renamed in #28948 and #28909, and this is semi-autogenerated PR to deprecate the old module names.
These are 9
Data.{Complex, Real}.xxxfiles that have been renamed toAnalysis.{Complex, Real}.xxx.I had forgotten about running
lake exe mk_allafter the deprecated modules had been generated.