[Merged by Bors] - chore: remove unnecessary simp call#28775
Closed
xroblot wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: remove unnecessary simp call#28775xroblot wants to merge 2 commits intoleanprover-community:masterfrom
simp call#28775xroblot wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary a3660d1c36Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
2 tasks
simp says that produce errorsimp says calls that produce errors
Member
|
I am not sure I understand, this currently works, right? |
Collaborator
Author
It seems some things have been fixed in the meantime, see : https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Lint.20error.20with.20.60Simp.20says.60 |
simp says calls that produce errorssimp call
Contributor
|
Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2025
cf. [#mathlib4 > Lint error with `Simp says`](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Lint.20error.20with.20.60Simp.20says.60)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
simp callsimp call
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
pechersky
pushed a commit
to pechersky/mathlib4
that referenced
this pull request
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. #mathlib4 > Lint error with `Simp says`