Skip to content

[Merged by Bors] - feat: the maximal atlas is closed under restriction#28701

Closed
grunweg wants to merge 7 commits intoleanprover-community:masterfrom
grunweg:restr-memmaxatlas
Closed

[Merged by Bors] - feat: the maximal atlas is closed under restriction#28701
grunweg wants to merge 7 commits intoleanprover-community:masterfrom
grunweg:restr-memmaxatlas

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Aug 20, 2025 •
edited
Loading

If G is a StructureGroupoid that is ClosedUnderRestriction,
if e is a chart in the maximal atlas of G, then so is any restriction e.restr s to an open set s.

In #28793, I will use this to give a more natural constructor for "f is an immersion at x".
From the path towards smooth immersions, embeddings and embedded submanifolds.

Open in Gitpod

@grunweg grunweg added the t-differential-geometry Manifolds etc label Aug 20, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 20, 2025 •
edited
Loading

PR summary cefe7b7756

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ StructureGroupoid.subtypeRestr_mem_maximalAtlas
+ restr_eqOnSource_restr
+ restr_inter_source
+ restr_mem_maximalAtlas
+ restr_symm_trans
+ symm_trans_restr

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Increase in tech debt: (relative, absolute) = (2.00, 0.67)
Current number Change Type
3 2 large files

Current commit 0941d88a71
Reference commit cefe7b7756

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg force-pushed the restr-memmaxatlas branch 2 times, most recently from 9e9b266 to 52b53b3 Compare August 23, 2025 07:08
This was referenced Aug 23, 2025
Closed
Open
grunweg added 3 commits August 27, 2025 20:28
@grunweg
chore: rename StructureGroupoid.restriction_in_maximalAtlas
89ab10e 
The old name did not follow the naming convention;
when adding restrOpen in the next commit, the distinction starts to matter.
@grunweg
feat: lemmas about EqOnSource and PartialHomeomorph.restr
7116509 
These are analogues to existing lemmas about subtypeRestr, but I want to
use .restr (not .subtypeRestr).
@grunweg
feat: if a structure groupoid G is closed under restriction,
165da7a 
if e is in the maximal atlas, so is e.restr s for any open set s.
@grunweg grunweg force-pushed the restr-memmaxatlas branch from 52b53b3 to 165da7a Compare August 27, 2025 18:28
ocfnash
ocfnash approved these changes Sep 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Topology/PartialHomeomorph.lean Outdated
Comment on lines +910 to +911
· simp
exact fun ⦃x⦄ ↦ congrFun rfl
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is a non-terminal simp: can you turn it into a simpa using ...?

Copy link
Copy Markdown
Contributor Author

@grunweg grunweg Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! In this case, simpa using ... does not work --- but simp is doing way too much anyway. I've pared the squeezed simp down to just a few rewrites I want to do: now, the code is longer, but the change of goal state is (imho) clearer.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 1, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 1, 2025
grunweg and others added 3 commits September 8, 2025 19:04
@grunweg @ocfnash
Apply suggestions from code review
d998cc2 
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@grunweg
Comment
e1965aa
@grunweg
Avoid non-terminal simp
f3762d7
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 8, 2025

Thanks for the review!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Sep 8, 2025
@grunweg
feat: the maximal atlas is closed under restriction (#28701)
28684c5 
If `G` is a `StructureGroupoid` that is `ClosedUnderRestriction`,
if `e` is a chart in the maximal atlas of `G`, then so is any restriction `e.restr s` to an open set `s`.

In #28793, I will use this to give a more natural constructor for "f is an immersion at x".
From the path towards smooth immersions, embeddings and embedded submanifolds.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 8, 2025

Build failed (retrying...):

@bryangingechen
Copy link
Copy Markdown
Contributor

bryangingechen commented Sep 8, 2025

Looks like there's a long line: https://github.com/leanprover-community/mathlib4/actions/runs/17558576504/job/49868994324#step:19:5376
bors r-

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 8, 2025

Canceled.

@ghost ghost removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 8, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 8, 2025

Thanks! Fixed now.
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Sep 8, 2025
@grunweg
feat: the maximal atlas is closed under restriction (#28701)
b81a477 
If `G` is a `StructureGroupoid` that is `ClosedUnderRestriction`,
if `e` is a chart in the maximal atlas of `G`, then so is any restriction `e.restr s` to an open set `s`.

In #28793, I will use this to give a more natural constructor for "f is an immersion at x".
From the path towards smooth immersions, embeddings and embedded submanifolds.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the maximal atlas is closed under restriction [Merged by Bors] - feat: the maximal atlas is closed under restriction Sep 8, 2025
@mathlib-bors mathlib-bors bot closed this Sep 8, 2025
@grunweg grunweg deleted the restr-memmaxatlas branch September 8, 2025 20:18
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
@grunweg @yuanyi-350
feat: the maximal atlas is closed under restriction (leanprover-commu…
7826d71 
…nity#28701)

If `G` is a `StructureGroupoid` that is `ClosedUnderRestriction`,
if `e` is a chart in the maximal atlas of `G`, then so is any restriction `e.restr s` to an open set `s`.

In leanprover-community#28793, I will use this to give a more natural constructor for "f is an immersion at x".
From the path towards smooth immersions, embeddings and embedded submanifolds.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
robertmaxton42 pushed a commit to robertmaxton42/mathlib4 that referenced this pull request Sep 11, 2025
@grunweg @robertmaxton42
feat: the maximal atlas is closed under restriction (leanprover-commu…
1a070fd 
…nity#28701)

If `G` is a `StructureGroupoid` that is `ClosedUnderRestriction`,
if `e` is a chart in the maximal atlas of `G`, then so is any restriction `e.restr s` to an open set `s`.

In leanprover-community#28793, I will use this to give a more natural constructor for "f is an immersion at x".
From the path towards smooth immersions, embeddings and embedded submanifolds.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
@grunweg @joelriou
feat: the maximal atlas is closed under restriction (leanprover-commu…
72359a5 
…nity#28701)

If `G` is a `StructureGroupoid` that is `ClosedUnderRestriction`,
if `e` is a chart in the maximal atlas of `G`, then so is any restriction `e.restr s` to an open set `s`.

In leanprover-community#28793, I will use this to give a more natural constructor for "f is an immersion at x".
From the path towards smooth immersions, embeddings and embedded submanifolds.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocfnash ocfnash ocfnash approved these changes

Assignees

@ocfnash ocfnash

Labels

t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grunweg @bryangingechen @ocfnash