Skip to content

[Merged by Bors] - feat(Order/Antisymmetrization): support AntisymmRel in gcongr_forward#28514

Closed
JovanGerb wants to merge 4 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-AntisymmRel
Closed

[Merged by Bors] - feat(Order/Antisymmetrization): support AntisymmRel in gcongr_forward#28514
JovanGerb wants to merge 4 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-AntisymmRel

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented Aug 16, 2025

This PR adds support for AntisymmRel in gcongr_forward, so that we can grw using the AntisymmRel (· ≤ ·) relation.

Requested in #mathlib4 > Announcement: New `grw` tactic @ 💬

Open in Gitpod

@github-actions github-actions bot added the t-order Order theory label Aug 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 16, 2025 •
edited
Loading

PR summary 64240cc631

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ AntisymmRel.left
+ AntisymmRel.right
+ exactAntisymmRelLeft
+ exactAntisymmRelRight

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@bryangingechen
Copy link
Copy Markdown
Contributor

bryangingechen commented Aug 18, 2025

Could you add a test? Alternatively, are there places where this can already be used to golf proofs?
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 18, 2025

✌️ JovanGerb can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 18, 2025
@JovanGerb
Copy link
Copy Markdown
Contributor Author

JovanGerb commented Aug 19, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 19, 2025
@JovanGerb
feat(Order/Antisymmetrization): support AntisymmRel in `gcongr_forw…
dc60430 
…ard` (#28514)

This PR adds support for `AntisymmRel` in `gcongr_forward`, so that we can `grw` using the `AntisymmRel (· ≤ ·)` relation.

Requested in [#mathlib4 > Announcement: New &#96;grw&#96; tactic @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Announcement.3A.20New.20.60grw.60.20tactic/near/534752659)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 19, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order/Antisymmetrization): support AntisymmRel in gcongr_forward [Merged by Bors] - feat(Order/Antisymmetrization): support AntisymmRel in gcongr_forward Aug 19, 2025
@mathlib-bors mathlib-bors bot closed this Aug 19, 2025
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Aug 20, 2025
@JovanGerb
feat(Order/Antisymmetrization): support AntisymmRel in `gcongr_forw…
5cc616b 
…ard` (leanprover-community#28514)

This PR adds support for `AntisymmRel` in `gcongr_forward`, so that we can `grw` using the `AntisymmRel (· ≤ ·)` relation.

Requested in [#mathlib4 > Announcement: New &leanprover-community#96;grw&leanprover-community#96; tactic @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Announcement.3A.20New.20.60grw.60.20tactic/near/534752659)
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@JovanGerb @Paul-Lez
feat(Order/Antisymmetrization): support AntisymmRel in `gcongr_forw…
5905e70 
…ard` (leanprover-community#28514)

This PR adds support for `AntisymmRel` in `gcongr_forward`, so that we can `grw` using the `AntisymmRel (· ≤ ·)` relation.

Requested in [#mathlib4 > Announcement: New &leanprover-community#96;grw&leanprover-community#96; tactic @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Announcement.3A.20New.20.60grw.60.20tactic/near/534752659)
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
@JovanGerb @pechersky
feat(Order/Antisymmetrization): support AntisymmRel in `gcongr_forw…
c8b4f59 
…ard` (leanprover-community#28514)

This PR adds support for `AntisymmRel` in `gcongr_forward`, so that we can `grw` using the `AntisymmRel (· ≤ ·)` relation.

Requested in [#mathlib4 > Announcement: New &leanprover-community#96;grw&leanprover-community#96; tactic @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Announcement.3A.20New.20.60grw.60.20tactic/near/534752659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JovanGerb @bryangingechen