Skip to content

[Merged by Bors] - chore(Analysis/InnerProductSpace/LinearMap): remove maxHeartbeats#28251

Closed
themathqueen wants to merge 1 commit intoleanprover-community:masterfrom
themathqueen:chore_ips_lm_1
Closed

[Merged by Bors] - chore(Analysis/InnerProductSpace/LinearMap): remove maxHeartbeats#28251
themathqueen wants to merge 1 commit intoleanprover-community:masterfrom
themathqueen:chore_ips_lm_1

Conversation

@themathqueen
Copy link
Copy Markdown
Collaborator

It's not needed anymore.


Open in Gitpod

@themathqueen
Copy link
Copy Markdown
Collaborator Author

easy

@github-actions github-actions bot added easy < 20s of review time. See the lifecycle page for guidelines. t-analysis Analysis (normed *, calculus) labels Aug 11, 2025
@github-actions
Copy link
Copy Markdown

PR summary ffac4c5b6c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.12)
Current number Change Type
8 -1 maxHeartBeats modifications

Current commit 4bfae84dfb
Reference commit ffac4c5b6c

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Aug 12, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 12, 2025
@eric-wieser
Copy link
Copy Markdown
Member

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Aug 12, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/InnerProductSpace/LinearMap): remove maxHeartbeats [Merged by Bors] - chore(Analysis/InnerProductSpace/LinearMap): remove maxHeartbeats Aug 12, 2025
@mathlib-bors mathlib-bors bot closed this Aug 12, 2025
@themathqueen themathqueen deleted the chore_ips_lm_1 branch August 12, 2025 02:51
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
vlad902 pushed a commit to vlad902/mathlib4 that referenced this pull request Aug 26, 2025
vlad902 pushed a commit to vlad902/mathlib4 that referenced this pull request Oct 4, 2025
vlad902 pushed a commit to vlad902/mathlib4 that referenced this pull request Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants