Skip to content

[Merged by Bors] - chore(Algebra/Order): generalize#28227

Closed
alreadydone wants to merge 2 commits intoleanprover-community:masterfrom
alreadydone:Generalize_Algebra/Order
Closed

[Merged by Bors] - chore(Algebra/Order): generalize#28227
alreadydone wants to merge 2 commits intoleanprover-community:masterfrom
alreadydone:Generalize_Algebra/Order

Conversation

@alreadydone
Copy link
Copy Markdown
Contributor

@alreadydone alreadydone commented Aug 11, 2025

Remove some ZeroLEOneClass assumptions.

Change some IsStrictOrderedRing to IsOrderedRing.

Remove some IsRightCancelAdd and replace some AddLeftStrictMono by AddLeftMono.


Open in Gitpod

@alreadydone alreadydone added t-algebra Algebra (groups, rings, fields, etc) t-order Order theory labels Aug 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 11, 2025

PR summary e704c683ed

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ pow_succ_nonneg
+ pow_succ_pos

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@alreadydone alreadydone added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 11, 2025
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 11, 2025
@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 14, 2025
Remove some `ZeroLEOneClass` assumptions.

Change some `IsStrictOrderedRing` to `IsOrderedRing`.

Remove some `IsRightCancelAdd` and replace some `AddLeftStrictMono` by `AddLeftMono`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 14, 2025

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

mathlib-bors bot pushed a commit that referenced this pull request Aug 14, 2025
Remove some `ZeroLEOneClass` assumptions.

Change some `IsStrictOrderedRing` to `IsOrderedRing`.

Remove some `IsRightCancelAdd` and replace some `AddLeftStrictMono` by `AddLeftMono`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Order): generalize [Merged by Bors] - chore(Algebra/Order): generalize Aug 14, 2025
@mathlib-bors mathlib-bors bot closed this Aug 14, 2025
@alreadydone alreadydone deleted the Generalize_Algebra/Order branch August 14, 2025 08:02
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
Remove some `ZeroLEOneClass` assumptions.

Change some `IsStrictOrderedRing` to `IsOrderedRing`.

Remove some `IsRightCancelAdd` and replace some `AddLeftStrictMono` by `AddLeftMono`.
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
Remove some `ZeroLEOneClass` assumptions.

Change some `IsStrictOrderedRing` to `IsOrderedRing`.

Remove some `IsRightCancelAdd` and replace some `AddLeftStrictMono` by `AddLeftMono`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants