Skip to content

[Merged by Bors] - feat(Topology/Path): add theorem about casting with rfl#28185

Closed
Sebi-Kumar wants to merge 1 commit intoleanprover-community:masterfrom
Sebi-Kumar:cast-rfl-rfl
Closed

[Merged by Bors] - feat(Topology/Path): add theorem about casting with rfl#28185
Sebi-Kumar wants to merge 1 commit intoleanprover-community:masterfrom
Sebi-Kumar:cast-rfl-rfl

Conversation

@Sebi-Kumar
Copy link
Copy Markdown
Contributor

Prove the trivial result p.cast rfl rfl = p for a path p, which serves as a useful result for the simplifier to know. Suggested by Aaron Liu at the discussion #Is there code for X? > Dealing with `Path.cast`.


To provide additional context, I am relatively new when it comes to contributing to Mathlib, and I am doing so as a part of the Fields Undergraduate Summer Research Program hosted at the University of Western Ontario under the supervision of Chris Kapulkin and Daniel Carranza. My goal is to contribute that the n-sphere is simply connected for n > 1.

Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-topology Topological spaces, uniform spaces, metric spaces, filters labels Aug 10, 2025
@github-actions
Copy link
Copy Markdown

PR summary a5b4f3bc80

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cast_rfl_rfl

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Collaborator

@kckennylau kckennylau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@plp127 plp127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plp127 plp127 added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 13, 2025
@j-loreaux
Copy link
Copy Markdown
Contributor

Sure, seems reasonable, but I can't think off the top of my head when it might come up.

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 22, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 22, 2025
Prove the trivial result `p.cast rfl rfl = p` for a path `p`, which serves as a useful result for the simplifier to know. Suggested by Aaron Liu at the discussion [#Is there code for X? > Dealing with &#96;Path.cast&#96;](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Dealing.20with.20.60Path.2Ecast.60).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Path): add theorem about casting with rfl [Merged by Bors] - feat(Topology/Path): add theorem about casting with rfl Aug 22, 2025
@mathlib-bors mathlib-bors bot closed this Aug 22, 2025
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…ommunity#28185)

Prove the trivial result `p.cast rfl rfl = p` for a path `p`, which serves as a useful result for the simplifier to know. Suggested by Aaron Liu at the discussion [#Is there code for X? > Dealing with &leanprover-community#96;Path.cast&leanprover-community#96;](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Dealing.20with.20.60Path.2Ecast.60).
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
…ommunity#28185)

Prove the trivial result `p.cast rfl rfl = p` for a path `p`, which serves as a useful result for the simplifier to know. Suggested by Aaron Liu at the discussion [#Is there code for X? > Dealing with &leanprover-community#96;Path.cast&leanprover-community#96;](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Dealing.20with.20.60Path.2Ecast.60).
FormulaRabbit81 pushed a commit to YaelDillies/mathlib4 that referenced this pull request Aug 30, 2025
…ommunity#28185)

Prove the trivial result `p.cast rfl rfl = p` for a path `p`, which serves as a useful result for the simplifier to know. Suggested by Aaron Liu at the discussion [#Is there code for X? > Dealing with &leanprover-community#96;Path.cast&leanprover-community#96;](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Dealing.20with.20.60Path.2Ecast.60).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants