[Merged by Bors] - feat(RingTheory): add HahnSeries.ofFinsupp#28136
Closed
wwylele wants to merge 3 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(RingTheory): add HahnSeries.ofFinsupp#28136wwylele wants to merge 3 commits intoleanprover-community:masterfrom
wwylele wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
7 tasks
PR summary 8623f65b75Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.HahnSeries.Addition | 699 | 770 | +71 (+10.16%) |
| Mathlib.RingTheory.HahnSeries.Basic | 620 | 621 | +1 (+0.16%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.HahnSeries.Basic |
1 |
Mathlib.RingTheory.HahnSeries.Lex |
63 |
Mathlib.RingTheory.HahnSeries.Addition |
71 |
Declarations diff
+ coeff_ofFinsupp
+ coeff_ofFinsuppLinearMap
+ ofFinsupp
+ ofFinsuppLinearMap
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Collaborator
|
It looks like your Hahn embedding proof uses |
Collaborator
Author
|
Got it. I have removed it |
ScottCarnahan
approved these changes
Aug 10, 2025
Collaborator
ScottCarnahan
left a comment
There was a problem hiding this comment.
Looks good to me.
Ruben-VandeVelde
approved these changes
Aug 10, 2025
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Seems okay
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
Part of #27043 Hahn's embedding theorem
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
Part of leanprover-community#27043 Hahn's embedding theorem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #27043 Hahn's embedding theorem