Skip to content

[Merged by Bors] - feat: add Matrix.vecMulVecLinear#28116

Closed
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser/matrix-more-linear
Closed

[Merged by Bors] - feat: add Matrix.vecMulVecLinear#28116
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser/matrix-more-linear

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

This is the bilinear version of Matrix.vecMulVec.


Open in Gitpod

This is the bilinear version of `Matrix.vecMulVec`.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

PR summary 3bca90fd1e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ vecMulVecBilin

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 8, 2025

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 8, 2025
eric-wieser and others added 2 commits August 8, 2025 16:34
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 8, 2025
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

@bryangingechen
Copy link
Copy Markdown
Contributor

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 8, 2025
This is the bilinear version of `Matrix.vecMulVec`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add Matrix.vecMulVecLinear [Merged by Bors] - feat: add Matrix.vecMulVecLinear Aug 8, 2025
@mathlib-bors mathlib-bors bot closed this Aug 8, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser/matrix-more-linear branch August 8, 2025 19:30
mathlib-bors bot pushed a commit that referenced this pull request Aug 16, 2025
This adds the other three versions after #28116 added one of the two vector/vector products; namely `mulVec`, `vecMul`, and `dotProduct`.

Further down the file we have more restrictive linear versions of these maps, which for now I leave unchanged besides some cross-references.
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
This is the bilinear version of `Matrix.vecMulVec`.
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…ity#28130)

This adds the other three versions after leanprover-community#28116 added one of the two vector/vector products; namely `mulVec`, `vecMul`, and `dotProduct`.

Further down the file we have more restrictive linear versions of these maps, which for now I leave unchanged besides some cross-references.
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
…ity#28130)

This adds the other three versions after leanprover-community#28116 added one of the two vector/vector products; namely `mulVec`, `vecMul`, and `dotProduct`.

Further down the file we have more restrictive linear versions of these maps, which for now I leave unchanged besides some cross-references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants