Skip to content

feat: RamifiedExtension and UnramifiedExtension types for InfinitePlace.Extensions#27979

Closed
smmercuri wants to merge 7 commits intoleanprover-community:masterfrom
smmercuri:smmercuri/UnramifiedExtension
Closed

feat: RamifiedExtension and UnramifiedExtension types for InfinitePlace.Extensions#27979
smmercuri wants to merge 7 commits intoleanprover-community:masterfrom
smmercuri:smmercuri/UnramifiedExtension

Conversation

@smmercuri
Copy link
Copy Markdown
Collaborator

@smmercuri smmercuri commented Aug 5, 2025

This PR continues the work from #24882.

Original PR: #24882


@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 5, 2025

PR summary 25b3be17c7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Extension
+ Extension.toRamifiedExtension
+ Extension.toUnramifiedExtension
+ IsConjugateLift
+ IsConjugateLift.isExtension
+ IsExtension
+ IsExtension.ne
+ IsExtension.not_isExtension_conjugate
+ IsExtension.not_isReal_of_not_isReal
+ IsLift
+ IsLift.isExtension
+ IsMixedExtension
+ IsUnmixedExtension
+ IsUnmixedExtension.isReal_of_isReal
+ RamifiedExtension
+ UnramifiedExtension
+ conjugate_comp
+ instance : Coe (v.RamifiedExtension L) (v.Extension L)
+ instance : Coe (v.UnramifiedExtension L) (v.Extension L)
+ isComplex
+ isComplex_of_isComplex
+ isExtension
+ isExtensionEquivSum
+ isExtension_conjugate_of_not_isExtension
+ isExtension_or_isExtension_conjugate
+ isLift_or_isConjugateLift
+ isRamified
+ isReal_comap
+ isUnramified
+ mk_embedding_comp
+ not_isReal
++ comap_eq
+++ isReal

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Aug 5, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 5, 2025
@riccardobrasca riccardobrasca self-assigned this Aug 18, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 19, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 19, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@smmercuri smmercuri closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants