Skip to content

feat: RamifiedExtension and UnramifiedExtension types for InfinitePlace.Extensions#24882

Closed
smmercuri wants to merge 6 commits intomasterfrom
smmercuri/UnramifiedExtension
Closed

feat: RamifiedExtension and UnramifiedExtension types for InfinitePlace.Extensions#24882
smmercuri wants to merge 6 commits intomasterfrom
smmercuri/UnramifiedExtension

Conversation

@smmercuri
Copy link
Copy Markdown
Collaborator

@smmercuri smmercuri commented May 14, 2025

  • v.RamifiedExtension L : the subtype of v.Extension L consisting of ramified extensions.
  • v.UnramifiedExtension L : the subtype of v.Extension L consisting of unramified extensions.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 14, 2025

PR summary f6d60e9f02

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Extension
+ Extension.toRamifiedExtension
+ Extension.toUnramifiedExtension
+ IsConjugateLift
+ IsConjugateLift.isExtension
+ IsExtension
+ IsExtension.ne
+ IsExtension.not_isExtension_conjugate
+ IsExtension.not_isReal_of_not_isReal
+ IsLift
+ IsLift.isExtension
+ IsMixedExtension
+ IsRamified
+ IsRamified.ne_conjugate
+ IsUnmixedExtension
+ IsUnmixedExtension.isReal_of_isReal
+ RamifiedExtension
+ UnramifiedExtension
+ conjugate_comp
+ instance : Coe (v.RamifiedExtension L) (v.Extension L)
+ instance : Coe (v.UnramifiedExtension L) (v.Extension L)
+ isComplex
+ isComplex_of_isComplex
+ isExtension
+ isExtensionEquivSum
+ isExtension_conjugate_of_not_isExtension
+ isExtension_or_isExtension_conjugate
+ isLift_or_isConjugateLift
+ isRamified
+ isRamified_iff
+ isReal_comap
+ isUnramified
+ mk_embedding_comp
+ not_isReal
++ comap_eq
+++ isReal

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label May 14, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented May 14, 2025

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 14, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 4, 2025
@smmercuri smmercuri added the WIP Work in progress label Jul 8, 2025
@smmercuri
Copy link
Copy Markdown
Collaborator Author

This PR has been migrated to a fork-based workflow: #27979

@smmercuri smmercuri closed this Aug 5, 2025
@YaelDillies YaelDillies deleted the smmercuri/UnramifiedExtension branch August 18, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) migrated-to-fork t-number-theory Number theory (also use t-algebra or t-analysis to specialize) WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants