Skip to content

[Merged by Bors] - chore(Algebra/Group/WithOne): injectivity of coe and map#27665

Closed
pechersky wants to merge 7 commits intoleanprover-community:masterfrom
pechersky:with-zero-coe-inj
Closed

[Merged by Bors] - chore(Algebra/Group/WithOne): injectivity of coe and map#27665
pechersky wants to merge 7 commits intoleanprover-community:masterfrom
pechersky:with-zero-coe-inj

Conversation

@pechersky
Copy link
Copy Markdown
Contributor


Open in Gitpod

@pechersky pechersky added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Jul 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 30, 2025

PR summary e0e3f4be35

Import changes exceeding 2%

% File
+2.40% Mathlib.Algebra.Group.WithOne.Defs

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Group.WithOne.Defs 292 299 +7 (+2.40%)
Mathlib.Algebra.Group.WithOne.Basic 315 318 +3 (+0.95%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Group.WithOne.Basic 3
Mathlib.Algebra.Group.WithOne.Defs 7

Declarations diff

+ coe_injective
+ map_inj
+ map_injective
+ map_injective'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 3, 2025

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 3, 2025
pechersky and others added 2 commits August 4, 2025 10:03
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Aug 4, 2025
@pechersky pechersky requested a review from eric-wieser August 4, 2025 16:19
@eric-wieser eric-wieser changed the title chore(Algebra/Group/WithOne): With{One,Zero}.coe_injective chore(Algebra/Group/WithOne): injectivity of coe and map Aug 5, 2025
@eric-wieser
Copy link
Copy Markdown
Member

bors merge

Thanks!

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 5, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 5, 2025
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 5, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Group/WithOne): injectivity of coe and map [Merged by Bors] - chore(Algebra/Group/WithOne): injectivity of coe and map Aug 5, 2025
@mathlib-bors mathlib-bors bot closed this Aug 5, 2025
Equilibris pushed a commit to Equilibris/mathlib4 that referenced this pull request Aug 7, 2025
…ver-community#27665)

Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
staroperator pushed a commit to staroperator/mathlib4 that referenced this pull request Aug 8, 2025
…ver-community#27665)

Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…ver-community#27665)

Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…ver-community#27665)

Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants