[Merged by Bors] - feat(Algebra/QuadraticAlgebra): custom structure for quadratic algebras#27511
[Merged by Bors] - feat(Algebra/QuadraticAlgebra): custom structure for quadratic algebras#27511Nebula691 wants to merge 55 commits intoleanprover-community:masterfrom
Conversation
PR summary 4a2cfa2512Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| @[simp] | ||
| theorem equivTuple_apply {R : Type*} (a b : R) (z : QuadraticAlgebra R a b) : | ||
| equivTuple a b z = ![z.re, z.im] := rfl |
There was a problem hiding this comment.
Does the simpNF linter not complain? Also, a and b can be implicit.
There was a problem hiding this comment.
it didn't, and making a and b implicit will break the theorems after it then it would ask me to specify which a and b am I using
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
eric-wieser
left a comment
There was a problem hiding this comment.
This looks great to me now, thanks!
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
There is now plenty of evidence that my original kneejerk reaction was misguided and that we should indeed have this two-fields structure in mathlib. My reasoning is that this is the minimal first step to unifying |
|
|
||
| end Neg | ||
|
|
||
| section AddGroup |
There was a problem hiding this comment.
Not super important, but in the section AddGroup there is no mention of any AddGroup.
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
…as (#27511) Discussed in [#Is there code for X? > Z[(1+sqrt(1+4k))/2] @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Z.5B.281.2Bsqrt.281.2B4k.29.29.2F2.5D/near/520523635) Co-authored-by: Edison Xie <yx3021@ic.ac.uk> Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk> Co-authored-by: Whysoserioushah <yx3021@ic.ac.uk> Co-authored-by: Whysoserioushah <109107491+Whysoserioushah@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: hongjiayang1 <jh1321@ic.ac.uk>
|
Pull request successfully merged into master. Build succeeded: |
…as (leanprover-community#27511) Discussed in [#Is there code for X? > Z&leanprover-community#91;(1+sqrt(1+4k))/2&leanprover-community#93; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Z.5B.281.2Bsqrt.281.2B4k.29.29.2F2.5D/near/520523635) Co-authored-by: Edison Xie <yx3021@ic.ac.uk> Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk> Co-authored-by: Whysoserioushah <yx3021@ic.ac.uk> Co-authored-by: Whysoserioushah <109107491+Whysoserioushah@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: hongjiayang1 <jh1321@ic.ac.uk>
…as (leanprover-community#27511) Discussed in [#Is there code for X? > Z&leanprover-community#91;(1+sqrt(1+4k))/2&leanprover-community#93; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Z.5B.281.2Bsqrt.281.2B4k.29.29.2F2.5D/near/520523635) Co-authored-by: Edison Xie <yx3021@ic.ac.uk> Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk> Co-authored-by: Whysoserioushah <yx3021@ic.ac.uk> Co-authored-by: Whysoserioushah <109107491+Whysoserioushah@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: hongjiayang1 <jh1321@ic.ac.uk>
…as (leanprover-community#27511) Discussed in [#Is there code for X? > Z&leanprover-community#91;(1+sqrt(1+4k))/2&leanprover-community#93; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Z.5B.281.2Bsqrt.281.2B4k.29.29.2F2.5D/near/520523635) Co-authored-by: Edison Xie <yx3021@ic.ac.uk> Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk> Co-authored-by: Whysoserioushah <yx3021@ic.ac.uk> Co-authored-by: Whysoserioushah <109107491+Whysoserioushah@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: hongjiayang1 <jh1321@ic.ac.uk>
…as (leanprover-community#27511) Discussed in [#Is there code for X? > Z&leanprover-community#91;(1+sqrt(1+4k))/2&leanprover-community#93; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Z.5B.281.2Bsqrt.281.2B4k.29.29.2F2.5D/near/520523635) Co-authored-by: Edison Xie <yx3021@ic.ac.uk> Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk> Co-authored-by: Whysoserioushah <yx3021@ic.ac.uk> Co-authored-by: Whysoserioushah <109107491+Whysoserioushah@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: hongjiayang1 <jh1321@ic.ac.uk>
Discussed in #Is there code for X? > Z[(1+sqrt(1+4k))/2] @ 💬
Co-authored-by: Edison Xie yx3021@ic.ac.uk
Co-authored-by: Kenny Lau kc_kennylau@yahoo.com.hk