[Merged by Bors] - chore(*): go through adaptation notes for lean4#6024#27348
Closed
Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(*): go through adaptation notes for lean4#6024#27348Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
We have some adaptation notes referring to lean4#6024, which changed elaboration subtly; some tricky unifications no longer get solved. I checked every reference to make sure that these still apply. We don't expect that this change gets reverted, so we can turn the remaining adaptation notes into regular comments.
PR summary ffe8eee4d3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (33.00, 0.39)
Current commit 19b2201b00 You can run this locally as
|
Contributor
|
Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
We have some adaptation notes referring to [lean4#6024](leanprover/lean4#6024), which changed elaboration subtly; some tricky unifications no longer get solved. I checked every reference to make sure that these still apply. We don't expect that this change gets reverted, so we can turn the remaining adaptation notes into regular comments.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…unity#27348) We have some adaptation notes referring to [lean4#6024](leanprover/lean4#6024), which changed elaboration subtly; some tricky unifications no longer get solved. I checked every reference to make sure that these still apply. We don't expect that this change gets reverted, so we can turn the remaining adaptation notes into regular comments.
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
…unity#27348) We have some adaptation notes referring to [lean4#6024](leanprover/lean4#6024), which changed elaboration subtly; some tricky unifications no longer get solved. I checked every reference to make sure that these still apply. We don't expect that this change gets reverted, so we can turn the remaining adaptation notes into regular comments.
Equilibris
pushed a commit
to Equilibris/mathlib4
that referenced
this pull request
Aug 7, 2025
…unity#27348) We have some adaptation notes referring to [lean4#6024](leanprover/lean4#6024), which changed elaboration subtly; some tricky unifications no longer get solved. I checked every reference to make sure that these still apply. We don't expect that this change gets reverted, so we can turn the remaining adaptation notes into regular comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some adaptation notes referring to lean4#6024, which changed elaboration subtly; some tricky unifications no longer get solved. I checked every reference to make sure that these still apply. We don't expect that this change gets reverted, so we can turn the remaining adaptation notes into regular comments.