Skip to content

[Merged by Bors] - feat(Logic/Equiv/Set): Equiv.monotone_image etc#27170

Closed
pechersky wants to merge 6 commits intoleanprover-community:masterfrom
pechersky:equiv-set-image-mono
Closed

[Merged by Bors] - feat(Logic/Equiv/Set): Equiv.monotone_image etc#27170
pechersky wants to merge 6 commits intoleanprover-community:masterfrom
pechersky:equiv-set-image-mono

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

@pechersky pechersky commented Jul 15, 2025

Open in Gitpod

@pechersky pechersky mentioned this pull request Jul 15, 2025
Closed
2 tasks
@github-actions github-actions bot added the t-logic Logic (model theory, etc) label Jul 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 15, 2025 •
edited
Loading

PR summary efb60912a8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ image_antitone
+ image_monotone
+ image_strictAnti
+ image_strictMono

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@pechersky pechersky added easy < 20s of review time. See the lifecycle page for guidelines. t-order Order theory labels Jul 15, 2025
eric-wieser
eric-wieser reviewed Jul 16, 2025
View reviewed changes
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 17, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 17, 2025
PatrickMassot
PatrickMassot reviewed Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add empty lines between lemmas?
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 18, 2025

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jul 18, 2025
@pechersky
Copy link
Copy Markdown
Contributor Author

pechersky commented Jul 18, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 18, 2025
@pechersky
feat(Logic/Equiv/Set): Equiv.monotone_image etc (#27170)
9bfb3dc
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 18, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Logic/Equiv/Set): Equiv.monotone_image etc [Merged by Bors] - feat(Logic/Equiv/Set): Equiv.monotone_image etc Jul 18, 2025
@mathlib-bors mathlib-bors bot closed this Jul 18, 2025
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@pechersky @callesonne
feat(Logic/Equiv/Set): Equiv.monotone_image etc (leanprover-communi…
df2df77 
…ty#27170)
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
@pechersky @hrmacbeth
feat(Logic/Equiv/Set): Equiv.monotone_image etc (leanprover-communi…
fb88344 
…ty#27170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@PatrickMassot PatrickMassot PatrickMassot left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-logic Logic (model theory, etc) t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pechersky @eric-wieser @PatrickMassot @Ruben-VandeVelde