Skip to content

[Merged by Bors] - chore(Gram-Schmidt): small tweaks#26894

Closed
grunweg wants to merge 9 commits intoleanprover-community:masterfrom
grunweg:gramSchmidttweaks
Closed

[Merged by Bors] - chore(Gram-Schmidt): small tweaks#26894
grunweg wants to merge 9 commits intoleanprover-community:masterfrom
grunweg:gramSchmidttweaks

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 8, 2025

  • improve formatting of the module doc-string
  • move all declarations to the InnerProductSpace namespace --- to make room for a VectorBundle.gramSchmidt (applying the same procedure point-wise to sections in vector bundles)
  • rename gramSchmidt_orthonormal(') to gramSchmidtNormed_orthonormal('): these are about gramSchmidtNormed, hence simply misnamed.

From the path towards geodesics and the Levi-Civita connection.
Co-authored-by: Patrick Massot patrickmassot@free.fr


Open in Gitpod

@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 8, 2025

PR summary 350e70c6ef

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ gramSchmidtNormed_orthonormal
+ gramSchmidtNormed_orthonormal'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 8, 2025
@grunweg grunweg mentioned this pull request Jul 8, 2025
35 tasks
Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 10, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 10, 2025
grunweg and others added 2 commits July 10, 2025 21:29
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 10, 2025

Thank you for the quick review!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 10, 2025
- improve formatting of the module doc-string
- move all declarations to the InnerProductSpace namespace
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 10, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Gram-Schmidt): small tweaks [Merged by Bors] - chore(Gram-Schmidt): small tweaks Jul 10, 2025
@mathlib-bors mathlib-bors bot closed this Jul 10, 2025
@grunweg grunweg deleted the gramSchmidttweaks branch July 10, 2025 20:55
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Jul 16, 2025
- improve formatting of the module doc-string
- move all declarations to the InnerProductSpace namespace
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
- improve formatting of the module doc-string
- move all declarations to the InnerProductSpace namespace
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
- improve formatting of the module doc-string
- move all declarations to the InnerProductSpace namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants