Skip to content

[Merged by Bors] - feat(VectorBundle/MDifferentiable): differentiability results for coordChange#26866

Closed
grunweg wants to merge 8 commits intoleanprover-community:masterfrom
grunweg:MR-diff-coordchange
Closed

[Merged by Bors] - feat(VectorBundle/MDifferentiable): differentiability results for coordChange#26866
grunweg wants to merge 8 commits intoleanprover-community:masterfrom
grunweg:MR-diff-coordchange

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 7, 2025 •
edited
Loading

These follow readily from their ContMDiff counterparts.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot patrickmassot@free.fr

Open in Gitpod

@grunweg
feat(VectorBundle/MDifferentiable): differentiability results for coo…
d902ebf 
…rdChange

These follow readily from the ContMDiff counterparts.
From the path towards geodesics and the Levi-Civita connection.
@github-actions github-actions bot added the t-differential-geometry Manifolds etc label Jul 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 7, 2025 •
edited
Loading

PR summary bacc86cc6c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ MDifferentiable.coordChange
+ MDifferentiable.coordChangeL
+ MDifferentiableAt.coordChange
+ MDifferentiableAt.coordChangeL
+ MDifferentiableOn.coordChange
+ MDifferentiableOn.coordChangeL
+ MDifferentiableWithinAt.coordChange
+ MDifferentiableWithinAt.coordChangeL
+ mdifferentiableAt_coordChangeL
+ mdifferentiableOn_coordChangeL
+ mdifferentiableOn_symm_coordChangeL

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

This was referenced Jul 7, 2025
Closed
Draft
sgouezel
sgouezel reviewed Jul 7, 2025
View reviewed changes
@sgouezel sgouezel added the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 7, 2025
@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 7, 2025
@grunweg grunweg removed awaiting-author A reviewer has asked the author a question or requested changes. merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 7, 2025
sgouezel
sgouezel reviewed Jul 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 16, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 16, 2025
grunweg and others added 4 commits July 17, 2025 01:19
@grunweg @sgouezel
Apply suggestions from code review
d997683 
Co-authored-by: Sebastien Gouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Golf
35e358c
@grunweg
Final tweak
3ac1ba6
@grunweg
Final and finaler
1d09913
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 16, 2025

Thank you for the careful review!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2025
@grunweg
feat(VectorBundle/MDifferentiable): differentiability results for coo…
c728e64 
…rdChange (#26866)

These follow readily from their ContMDiff counterparts.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 16, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(VectorBundle/MDifferentiable): differentiability results for coordChange [Merged by Bors] - feat(VectorBundle/MDifferentiable): differentiability results for coordChange Jul 16, 2025
@mathlib-bors mathlib-bors bot closed this Jul 16, 2025
@grunweg grunweg deleted the MR-diff-coordchange branch July 16, 2025 23:41
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@grunweg @callesonne
feat(VectorBundle/MDifferentiable): differentiability results for coo…
eb75b36 
…rdChange (leanprover-community#26866)

These follow readily from their ContMDiff counterparts.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
@grunweg @hrmacbeth
feat(VectorBundle/MDifferentiable): differentiability results for coo…
40a410f 
…rdChange (leanprover-community#26866)

These follow readily from their ContMDiff counterparts.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grunweg @sgouezel