Skip to content

[Merged by Bors] - feat(VectorBundle/MDifferentiable): add some basic API#26865

Closed
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:MR-mdiff-zerosection
Closed

[Merged by Bors] - feat(VectorBundle/MDifferentiable): add some basic API#26865
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:MR-mdiff-zerosection

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 7, 2025 •
edited
Loading

mirroring the development in VectorBundle/Basic.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot patrickmassot@free.fr

Open in Gitpod

@grunweg
feat(VectorBundle/MDifferentiable): add some basic API
23fdeab 
mirroring the development in VectorBundle/Basic.

From the path towards geodesics and the Levi-Civita connection.
@github-actions github-actions bot added the t-differential-geometry Manifolds etc label Jul 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 7, 2025 •
edited
Loading

PR summary 19d3601142

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mdifferentiableAt_proj
+ mdifferentiableAt_section
+ mdifferentiableAt_zeroSection
+ mdifferentiableOn_proj
+ mdifferentiableOn_zeroSection
+ mdifferentiableWithinAt_proj
+ mdifferentiableWithinAt_section
+ mdifferentiableWithinAt_zeroSection
+ mdifferentiable_proj
+ mdifferentiable_zeroSection

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg mentioned this pull request Jul 7, 2025
Draft
35 tasks
@sgouezel
Copy link
Copy Markdown
Contributor

sgouezel commented Jul 7, 2025

Doesn't build, can you fix it?

@sgouezel sgouezel added the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 7, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 7, 2025

Sure, on it!

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 7, 2025

Should be fixed now; I needed to copy over two more lemmas.

@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 7, 2025
@sgouezel
Copy link
Copy Markdown
Contributor

sgouezel commented Jul 7, 2025

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jul 7, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jul 7, 2025
@grunweg
feat(VectorBundle/MDifferentiable): add some basic API (#26865)
bacc86c 
mirroring the development in VectorBundle/Basic.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 7, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(VectorBundle/MDifferentiable): add some basic API [Merged by Bors] - feat(VectorBundle/MDifferentiable): add some basic API Jul 7, 2025
@mathlib-bors mathlib-bors bot closed this Jul 7, 2025
@grunweg grunweg deleted the MR-mdiff-zerosection branch July 7, 2025 20:25
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 7, 2025

Thanks for the quick review!

BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Jul 16, 2025
@grunweg @BeibeiX0
feat(VectorBundle/MDifferentiable): add some basic API (leanprover-co…
e3eb16e 
…mmunity#26865)

mirroring the development in VectorBundle/Basic.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@grunweg @callesonne
feat(VectorBundle/MDifferentiable): add some basic API (leanprover-co…
49be61e 
…mmunity#26865)

mirroring the development in VectorBundle/Basic.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
@grunweg @hrmacbeth
feat(VectorBundle/MDifferentiable): add some basic API (leanprover-co…
3b3b348 
…mmunity#26865)

mirroring the development in VectorBundle/Basic.

From the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grunweg @sgouezel