[Merged by Bors] - feat(ValuativeRel): MulArchimedean (ValueGroupWithZero R) when IsRankLeOne#26833
Closed
pechersky wants to merge 4 commits intoleanprover-community:masterfrom
Closed
Conversation
…LeOne with a proof_wanted for the reverse implication
PR summary 962b24680eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
4 tasks
Collaborator
|
Does Archimedean.exists_orderAddMonoidHom_real_injective help with the reverse direction? |
Contributor
Author
|
Yes! We just merged earlier today a use of that lemma in #27436. Thank you for contributing and your work toward Hahn Embedding! It will be very useful for rank-n valuations. |
pechersky
commented
Jul 25, 2025
Collaborator
|
Haha I missed the other PR. Glad I could help |
3 tasks
Member
|
Is "with a proof_wanted for the reverse implication" as claimed in the PR description still true? |
Member
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
…LeOne (#26833) The converse (for any compatible valuation) is `ValuativeRel.isRankLeOne_iff_mulArchimedean` which is in a later file since it requires a larger theory of reals. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Equilibris
pushed a commit
to Equilibris/mathlib4
that referenced
this pull request
Aug 7, 2025
…LeOne (leanprover-community#26833) The converse (for any compatible valuation) is `ValuativeRel.isRankLeOne_iff_mulArchimedean` which is in a later file since it requires a larger theory of reals. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…LeOne (leanprover-community#26833) The converse (for any compatible valuation) is `ValuativeRel.isRankLeOne_iff_mulArchimedean` which is in a later file since it requires a larger theory of reals. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…LeOne (leanprover-community#26833) The converse (for any compatible valuation) is `ValuativeRel.isRankLeOne_iff_mulArchimedean` which is in a later file since it requires a larger theory of reals. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The converse (for any compatible valuation) is
ValuativeRel.isRankLeOne_iff_mulArchimedeanwhich is in a later file since it requires a larger theory of reals.