Skip to content

[Merged by Bors] - chore(RingTheory/Valuation): generalize IsEquiv iffs to Ring#26826

Closed
pechersky wants to merge 1 commit intoleanprover-community:masterfrom
pechersky:val-isequiv-ring-gen
Closed

[Merged by Bors] - chore(RingTheory/Valuation): generalize IsEquiv iffs to Ring#26826
pechersky wants to merge 1 commit intoleanprover-community:masterfrom
pechersky:val-isequiv-ring-gen

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

before they were aliased out of iffs that showed that these conditions were sufficied to prove IsEquiv
but that is only true in a divison ring context
while the inequalities remain valid even in Ring


Open in Gitpod

before they were aliased out of iffs that showed that these conditions
were sufficied to prove IsEquiv
but that is only true in a divison ring context
while the inequalities remain valid even in Ring
@pechersky pechersky added t-analysis Analysis (normed *, calculus) t-algebra Algebra (groups, rings, fields, etc) easy < 20s of review time. See the lifecycle page for guidelines. and removed t-analysis Analysis (normed *, calculus) labels Jul 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 6, 2025

PR summary 00c9085f64

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ eq_one_iff_eq_one
+ le_one_iff_le_one
+ lt_iff_lt
+ lt_one_iff_lt_one
- IsEquiv.eq_one_iff_eq_one
- IsEquiv.le_one_iff_le_one
- IsEquiv.lt_iff_lt
- IsEquiv.lt_one_iff_lt_one
---- _

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adamtopaz
Copy link
Copy Markdown
Contributor

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jul 6, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jul 6, 2025
before they were aliased out of iffs that showed that these conditions were sufficied to prove IsEquiv
but that is only true in a divison ring context
while the inequalities remain valid even in Ring
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 6, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/Valuation): generalize IsEquiv iffs to Ring [Merged by Bors] - chore(RingTheory/Valuation): generalize IsEquiv iffs to Ring Jul 6, 2025
@mathlib-bors mathlib-bors bot closed this Jul 6, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 7, 2025
…ver-community#26826)

before they were aliased out of iffs that showed that these conditions were sufficied to prove IsEquiv
but that is only true in a divison ring context
while the inequalities remain valid even in Ring
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
…ver-community#26826)

before they were aliased out of iffs that showed that these conditions were sufficied to prove IsEquiv
but that is only true in a divison ring context
while the inequalities remain valid even in Ring
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
…ver-community#26826)

before they were aliased out of iffs that showed that these conditions were sufficied to prove IsEquiv
but that is only true in a divison ring context
while the inequalities remain valid even in Ring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants