Skip to content

[Merged by Bors] - feat: product rule for Lie bracket on manifolds#26743

Closed
grunweg wants to merge 36 commits intoleanprover-community:masterfrom
grunweg:productrule-liebracket
Closed

[Merged by Bors] - feat: product rule for Lie bracket on manifolds#26743
grunweg wants to merge 36 commits intoleanprover-community:masterfrom
grunweg:productrule-liebracket

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 4, 2025

On the path towards geodesics and the Levi-Civita connection.

Open in Gitpod

@grunweg grunweg added WIP Work in progress t-differential-geometry Manifolds etc labels Jul 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2025 •
edited
Loading

PR summary 7c0aa26a8b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ DifferentiableWithinAt.mdifferentiableWithinAt_of_comp_extChartAt_symm
+ MDifferentiableWithinAt.differentiableWithinAt_comp_extChartAt_symm
+ fderivWithin_extChartAt_comp_extChartAt_symm_range
+ mfderivWithin_extChartAt_symm_inverse_apply
+ mfderivWithin_range_extChartAt_symm
+ mfderiv_extChartAt_inverse_comp_mfderivWithin_extChartAT_symm
+ mfderiv_extChartAt_self
+ mfderiv_extChart_inverse_comp_aux
+ mlieBracketWithin_smul_left
+ mlieBracketWithin_smul_right
+ mlieBracket_smul_left
+ mlieBracket_smul_right
+ mpullbackWithin_const_smul
+ mpullbackWithin_const_smul_apply
+ mpullback_const_smul
+ mpullback_const_smul_apply
+ mpullback_mfderivWithin_apply_smul

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

Increase in tech debt: (relative, absolute) = (8.00, 0.00)
Current number Change Type
10057 8 backward.isDefEq

Current commit da9343e40c
Reference commit 7c0aa26a8b

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg mentioned this pull request Jul 4, 2025
Draft
35 tasks
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Jul 4, 2025
@grunweg
WIP: product rule for Lie brackets on manifolds -- copy-pasted from l…
f24e90b 
…eanprover-community#26743
@grunweg grunweg changed the title WIP: product rule for Lie bracket on manifolds feat: product rule for Lie bracket on manifolds Nov 19, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 20, 2025

This PR is now sorry-free (thanks @Deicyde for solving the last sorry), but still in need of some clean-up.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 26, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

mathlib4-merge-conflict-bot commented Nov 26, 2025

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 26, 2025
@grunweg grunweg removed the WIP Work in progress label Feb 18, 2026
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Feb 18, 2026

At long last, this PR may be ready for review. (It is also possible further clean-up is necessary.) Would you like to take a look, @sgouezel?

@grunweg grunweg requested a review from sgouezel February 18, 2026 09:35
@grunweg grunweg mentioned this pull request Feb 24, 2026
Closed
@mathlib-merge-conflicts
Copy link
Copy Markdown

mathlib-merge-conflicts bot commented Mar 2, 2026

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 2, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 2, 2026
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Mar 3, 2026
@grunweg
chore: cherry-pick Lie bracket changes from leanprover-community#26743
7520498
@sgouezel
Copy link
Copy Markdown
Contributor

sgouezel commented Mar 6, 2026

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 6, 2026

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 6, 2026
@PatrickMassot
Copy link
Copy Markdown
Member

PatrickMassot commented Mar 6, 2026

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 6, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 6, 2026
@grunweg @Deicyde @michaellee94
feat: product rule for Lie bracket on manifolds (#26743)
2e3bc24 
On the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Jack McCarthy <37917934+Deicyde@users.noreply.github.com>
Co-authored-by: michaellee94 <michael.a.rodrigues.lee@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 6, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: product rule for Lie bracket on manifolds [Merged by Bors] - feat: product rule for Lie bracket on manifolds Mar 6, 2026
@mathlib-bors mathlib-bors bot closed this Mar 6, 2026
@grunweg grunweg deleted the productrule-liebracket branch March 6, 2026 17:07
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 8, 2026
@grunweg @Deicyde
@michaellee94 @xroblot
feat: product rule for Lie bracket on manifolds (leanprover-community…
ad43c58 
…#26743)

On the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Jack McCarthy <37917934+Deicyde@users.noreply.github.com>
Co-authored-by: michaellee94 <michael.a.rodrigues.lee@gmail.com>
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 9, 2026
@grunweg @Deicyde
@michaellee94 @xroblot
feat: product rule for Lie bracket on manifolds (leanprover-community…
6378233 
…#26743)

On the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Jack McCarthy <37917934+Deicyde@users.noreply.github.com>
Co-authored-by: michaellee94 <michael.a.rodrigues.lee@gmail.com>
seewoo5 pushed a commit to seewoo5/mathlib4 that referenced this pull request Mar 9, 2026
@grunweg @Deicyde
@michaellee94 @seewoo5
feat: product rule for Lie bracket on manifolds (leanprover-community…
9a2afb3 
…#26743)

On the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Jack McCarthy <37917934+Deicyde@users.noreply.github.com>
Co-authored-by: michaellee94 <michael.a.rodrigues.lee@gmail.com>
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 10, 2026
@grunweg @Deicyde
@michaellee94 @xroblot
feat: product rule for Lie bracket on manifolds (leanprover-community…
af0c5a5 
…#26743)

On the path towards geodesics and the Levi-Civita connection.

Co-authored-by: Jack McCarthy <37917934+Deicyde@users.noreply.github.com>
Co-authored-by: michaellee94 <michael.a.rodrigues.lee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees

@PatrickMassot PatrickMassot

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@grunweg @mathlib4-merge-conflict-bot @sgouezel @PatrickMassot @Deicyde @michaellee94