Skip to content

[Merged by Bors] - feat(RingTheory/ValuativeRel): additional API to prepare for refactor#26712

Closed
pechersky wants to merge 3 commits intoleanprover-community:masterfrom
pechersky:valuative-rel-base-api
Closed

[Merged by Bors] - feat(RingTheory/ValuativeRel): additional API to prepare for refactor#26712
pechersky wants to merge 3 commits intoleanprover-community:masterfrom
pechersky:valuative-rel-base-api

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

@pechersky pechersky commented Jul 4, 2025

some helper lemmas that will be used in downstream refactor of Valued PRs

Open in Gitpod

@pechersky
feat(RingTheory/ValuativeRel): additional API to prepare for refactor
d69e17a 
some helper lemmas that will be used in downstream refactor of Valued PRs
@pechersky pechersky added t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-analysis Analysis (normed *, calculus) t-algebra Algebra (groups, rings, fields, etc) labels Jul 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2025 •
edited
Loading

PR summary e7c314d39b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ValueGroupWithZero.lift_mul
+ ValueGroupWithZero.lift_one
+ ValueGroupWithZero.lift_valuation
+ ValueGroupWithZero.lift_zero
+ ValueGroupWithZero.mk_lt_mk
+ _root_.Valuation.Compatible.ofValuation

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@pechersky pechersky mentioned this pull request Jul 4, 2025
Closed
1 task
mariainesdff
mariainesdff reviewed Jul 4, 2025
View reviewed changes
Mathlib/RingTheory/Valuation/ValuativeRel.lean
{S Γ : Type*} [CommRing S]
[LinearOrderedCommGroupWithZero Γ]
(v : Valuation S Γ) : @Valuation.Compatible _ _ _ _ v (.ofValuation v) := by
letI := ValuativeRel.ofValuation v
Copy link
Copy Markdown
Contributor

@mariainesdff mariainesdff Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
letI := ValuativeRel.ofValuation v
let := ValuativeRel.ofValuation v

(untested)

@mariainesdff
Copy link
Copy Markdown
Contributor

mariainesdff commented Jul 4, 2025

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2025

🚀 Pull request has been placed on the maintainer queue by mariainesdff.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 4, 2025
@adamtopaz
Copy link
Copy Markdown
Contributor

adamtopaz commented Jul 4, 2025

Thanks!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 4, 2025

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jul 4, 2025
@pechersky
Copy link
Copy Markdown
Contributor Author

pechersky commented Jul 4, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 5, 2025
@pechersky
feat(RingTheory/ValuativeRel): additional API to prepare for refactor (…
e8ef7e1 
…#26712)

some helper lemmas that will be used in downstream refactor of Valued PRs




Co-authored-by: Yakov Pechersky <ffxen158@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 5, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/ValuativeRel): additional API to prepare for refactor [Merged by Bors] - feat(RingTheory/ValuativeRel): additional API to prepare for refactor Jul 5, 2025
@mathlib-bors mathlib-bors bot closed this Jul 5, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 7, 2025
@pechersky @joelriou
feat(RingTheory/ValuativeRel): additional API to prepare for refactor (…
cfc2daf 
…leanprover-community#26712)

some helper lemmas that will be used in downstream refactor of Valued PRs




Co-authored-by: Yakov Pechersky <ffxen158@gmail.com>
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@pechersky @callesonne
feat(RingTheory/ValuativeRel): additional API to prepare for refactor (…
9e0f0ef 
…leanprover-community#26712)

some helper lemmas that will be used in downstream refactor of Valued PRs




Co-authored-by: Yakov Pechersky <ffxen158@gmail.com>
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
@pechersky @hrmacbeth
feat(RingTheory/ValuativeRel): additional API to prepare for refactor (…
d4c9cce 
…leanprover-community#26712)

some helper lemmas that will be used in downstream refactor of Valued PRs




Co-authored-by: Yakov Pechersky <ffxen158@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariainesdff mariainesdff mariainesdff left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc) t-analysis Analysis (normed *, calculus) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pechersky @mariainesdff @adamtopaz