Skip to content

[Merged by Bors] - feat: missing congruence lemmas for mdifferentiability#26709

Closed
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:mfderiv-congr-lemmas
Closed

[Merged by Bors] - feat: missing congruence lemmas for mdifferentiability#26709
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:mfderiv-congr-lemmas

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 3, 2025

Each of these lemmas has a ContMDiff analogue, this is how this PR was made.

From the path towards geodesics and the Levi-Civita connection.
Co-authored-by: Patrick Massot patrickmassot@free.fr

Open in Gitpod

@grunweg
feat: missing congruence lemmas for mdifferentiability
41dd17f 
Each of these lemmas has a ContMDiff analogue, this is how this PR was made.
@grunweg grunweg mentioned this pull request Jul 3, 2025
Draft
35 tasks
@github-actions github-actions bot added the t-differential-geometry Manifolds etc label Jul 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2025

PR summary db5c7f72b9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Filter.EventuallyEq.mdifferentiableAt_iff
+ Filter.EventuallyEq.mdifferentiablefWithinAt_iff
+ MDifferentiableOn.congr
+ MDifferentiableWithinAt.congr_of_mem
+ mdifferentiableOn_congr
+ mdifferentiableWithinAt_congr
+ mdifferentiableWithinAt_congr_of_mem

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

ocfnash
ocfnash approved these changes Jul 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

bors d+

Mathlib/Geometry/Manifold/MFDeriv/Basic.lean
apply h.congr_of_eventuallyEq _ (mem_of_mem_nhds h₁ :)
rwa [nhdsWithin_univ]

theorem mdifferentiableWithinAt_congr (h₁ : ∀ y ∈ s, f₁ y = f y) (hx : f₁ x = f x) :
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts about using Set.EqOn here (and below)?

Copy link
Copy Markdown
Contributor Author

@grunweg grunweg Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me start at the meta level first: the current phrasing was copied from their ContMDiff counterparts; if we change these, we should also change the others (and also look at the differentiable/contDiff versions). I think this should be a follow-up PR, if any.

Should we do this? Good question. I think all of these lemmas could use Set.EqOn, but I'm not sure this would have an immediate use. If you feel strongly, I can make a future PR changing all of these.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 4, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 4, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 4, 2025

Thanks for the quick review!

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 4, 2025

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 4, 2025
@grunweg
feat: missing congruence lemmas for mdifferentiability (#26709)
26ee342 
Each of these lemmas has a ContMDiff analogue, this is how this PR was made.

From the path towards geodesics and the Levi-Civita connection.
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 4, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: missing congruence lemmas for mdifferentiability [Merged by Bors] - feat: missing congruence lemmas for mdifferentiability Jul 4, 2025
@mathlib-bors mathlib-bors bot closed this Jul 4, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 7, 2025
@grunweg @joelriou
feat: missing congruence lemmas for mdifferentiability (leanprover-co…
e65ce1b 
…mmunity#26709)

Each of these lemmas has a ContMDiff analogue, this is how this PR was made.

From the path towards geodesics and the Levi-Civita connection.
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@grunweg @callesonne
feat: missing congruence lemmas for mdifferentiability (leanprover-co…
3e94353 
…mmunity#26709)

Each of these lemmas has a ContMDiff analogue, this is how this PR was made.

From the path towards geodesics and the Levi-Civita connection.
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
@grunweg @hrmacbeth
feat: missing congruence lemmas for mdifferentiability (leanprover-co…
b0a29e7 
…mmunity#26709)

Each of these lemmas has a ContMDiff analogue, this is how this PR was made.

From the path towards geodesics and the Levi-Civita connection.
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocfnash ocfnash ocfnash approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grunweg @ocfnash