Skip to content

[Merged by Bors] - feat: ContDiffOn.iUnion#26688

Closed
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
grunweg:contDiffOn_iunion
Closed

[Merged by Bors] - feat: ContDiffOn.iUnion#26688
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
grunweg:contDiffOn_iunion

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 3, 2025

Analogue of #26673 for ContDifferentiableOn.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2025 •
edited
Loading

PR summary 7672327e9c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ContDiffOn.iUnion_of_isOpen
+ ContDiffOn.union_of_isOpen
+ contDiffOn_iUnion_iff_of_isOpen
+ contDiffOn_union_iff_of_isOpen
+ contDiff_of_contDiffOn_iUnion_of_isOpen
+ contDiff_of_contDiffOn_union_of_isOpen

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Increase in tech debt: (relative, absolute) = (1.00, 0.33)
Current number Change Type
3 1 large files

Current commit be007b6769
Reference commit 7672327e9c

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Jul 3, 2025
@grunweg grunweg changed the title feat: ContDifferentiableOn.iUnion feat: ContDiffOn.iUnion Jul 3, 2025
@grunweg grunweg mentioned this pull request Jul 3, 2025
Draft
35 tasks
@grunweg grunweg force-pushed the contDiffOn_iunion branch from 5dcb278 to 8cb7632 Compare July 3, 2025 18:32
grunweg
grunweg commented Jul 3, 2025
View reviewed changes
grunweg
grunweg commented Jul 3, 2025
View reviewed changes
sgouezel
sgouezel reviewed Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 3, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 3, 2025
@grunweg @sgouezel
Apply suggestions from code review
58d0987 
Co-authored-by: Sebastien Gouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 3, 2025

Thanks for the fast review!
bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 3, 2025

Canceled.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 3, 2025

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 3, 2025
@grunweg
feat: ContDiffOn.iUnion (#26688)
90fee9d 
Analogue of #26673 for `ContDifferentiableOn`.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 3, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: ContDiffOn.iUnion [Merged by Bors] - feat: ContDiffOn.iUnion Jul 3, 2025
@mathlib-bors mathlib-bors bot closed this Jul 3, 2025
@grunweg grunweg deleted the contDiffOn_iunion branch July 3, 2025 22:52
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 7, 2025
@grunweg @joelriou
feat: ContDiffOn.iUnion (leanprover-community#26688)
f0adadb 
Analogue of leanprover-community#26673 for `ContDifferentiableOn`.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@grunweg @callesonne
feat: ContDiffOn.iUnion (leanprover-community#26688)
1bad7af 
Analogue of leanprover-community#26673 for `ContDifferentiableOn`.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
@grunweg @hrmacbeth
feat: ContDiffOn.iUnion (leanprover-community#26688)
2c35d14 
Analogue of leanprover-community#26673 for `ContDifferentiableOn`.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-analysis Analysis (normed *, calculus)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grunweg @sgouezel