Skip to content

[Merged by Bors] - feat: MDifferentiableOn.iUnion#26687

Closed
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:mdifferentiableOn_iunion
Closed

[Merged by Bors] - feat: MDifferentiableOn.iUnion#26687
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:mdifferentiableOn_iunion

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 3, 2025

Analogue of #26673 for MDifferentiableOn.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.

Open in Gitpod

@github-actions github-actions bot added the t-differential-geometry Manifolds etc label Jul 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2025 •
edited
Loading

PR summary 7672327e9c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ MDifferentiableOn.iUnion_of_isOpen
+ MDifferentiableOn.union_of_isOpen
+ mdifferentiableOn_iUnion_iff_of_isOpen
+ mdifferentiableOn_union_iff_of_isOpen
+ mdifferentiable_of_mdifferentiableOn_iUnion_of_isOpen
+ mdifferentiable_of_mdifferentiableOn_union_of_isOpen

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg mentioned this pull request Jul 3, 2025
Draft
35 tasks
sgouezel
sgouezel reviewed Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 3, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 3, 2025
@grunweg @sgouezel
Apply suggestions from code review
eef7369 
Co-authored-by: Sebastien Gouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 3, 2025

Thanks for the quick review!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 3, 2025
@grunweg
feat: MDifferentiableOn.iUnion (#26687)
53ab92a 
Analogue of #26673 for `MDifferentiableOn`.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 3, 2025

Pull request successfully merged into master.

Build succeeded:

  • CI Success

@mathlib-bors mathlib-bors bot changed the title feat: MDifferentiableOn.iUnion [Merged by Bors] - feat: MDifferentiableOn.iUnion Jul 3, 2025
@mathlib-bors mathlib-bors bot closed this Jul 3, 2025
@grunweg grunweg deleted the mdifferentiableOn_iunion branch July 3, 2025 22:53
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 7, 2025
@grunweg @joelriou
feat: MDifferentiableOn.iUnion (leanprover-community#26687)
557e93b 
Analogue of leanprover-community#26673 for `MDifferentiableOn`.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@grunweg @callesonne
feat: MDifferentiableOn.iUnion (leanprover-community#26687)
ea15bae 
Analogue of leanprover-community#26673 for `MDifferentiableOn`.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
@grunweg @hrmacbeth
feat: MDifferentiableOn.iUnion (leanprover-community#26687)
425f426 
Analogue of leanprover-community#26673 for `MDifferentiableOn`.

Transitive mathlib clean-up from the path towards geodesics and the Levi-Civita connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grunweg @sgouezel