[Merged by Bors] - chore(Geometry/Manifold/VectorBundle/Basic): make some arguments implicit#26677
Closed
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(Geometry/Manifold/VectorBundle/Basic): make some arguments implicit#26677grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
…pace} These lemmas are usually used for rewriting, and s occurs on both the left and right hand side.
PR summary 7672327e9cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
|
Does the same argument not apply to contMDiffWithinAt_section? |
Contributor
Author
|
Good point, it should. Let me try how this goes. |
contMDiff(Within)At_{section,totalSpace}
Contributor
Author
|
This seems to work well (it built locally, for instance): I'd say this is ready for review again. |
Contributor
|
Could you also do it for |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
…icit (#26677) All of these are in iff lemmas, which are almost always used for rewriting, and occur on both sides of the equation. Part of the path towards geodesics and the Levi-Civita connection. Co-authored by: @PatrickMassot
Contributor
|
Pull request successfully merged into master. Build succeeded: |
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Jul 7, 2025
…icit (leanprover-community#26677) All of these are in iff lemmas, which are almost always used for rewriting, and occur on both sides of the equation. Part of the path towards geodesics and the Levi-Civita connection. Co-authored by: @PatrickMassot
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…icit (leanprover-community#26677) All of these are in iff lemmas, which are almost always used for rewriting, and occur on both sides of the equation. Part of the path towards geodesics and the Levi-Civita connection. Co-authored by: @PatrickMassot
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
…icit (leanprover-community#26677) All of these are in iff lemmas, which are almost always used for rewriting, and occur on both sides of the equation. Part of the path towards geodesics and the Levi-Civita connection. Co-authored by: @PatrickMassot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these are in iff lemmas, which are almost always used for rewriting, and occur on both sides of the equation.
Part of the path towards geodesics and the Levi-Civita connection.
Co-authored by: @PatrickMassot