[Merged by Bors] - feat(AlgebraicTopology): application of the retract argument to model categories#26166
Closed
joelriou wants to merge 63 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(AlgebraicTopology): application of the retract argument to model categories#26166joelriou wants to merge 63 commits intoleanprover-community:masterfrom
joelriou wants to merge 63 commits intoleanprover-community:masterfrom
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jun 19, 2025
Contributor
robin-carlier
left a comment
There was a problem hiding this comment.
Very nice!
I did not individually record them, but basically all my remaining comments are about the tactic mode rw; exact that can be avoided by directly using the mem field or ..._iff _|>.mpr ... pattern.
Co-authored-by: Robin Carlier <57142648+robin-carlier@users.noreply.github.com>
Contributor
Author
|
Thanks for the reviews!
As tactic mode is unexpensive here, I have kept it in a few situations. |
Contributor
|
Thanks then! CI is having troubles right now but build and lint pass so I guess it’s safe to maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by robin-carlier. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
… categories (#26166) Basic consequences of the retract argument are obtained for model categories: cofibrations are exactly the morphisms that have the left lifting property with respect to trivial fibrations, etc. We deduce various properties of cofibrations, fibrations and weak equivalences in model categories (e.g. they are stable by composition). Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
joelriou
added a commit
to joelriou/mathlib4
that referenced
this pull request
Jul 7, 2025
… categories (leanprover-community#26166) Basic consequences of the retract argument are obtained for model categories: cofibrations are exactly the morphisms that have the left lifting property with respect to trivial fibrations, etc. We deduce various properties of cofibrations, fibrations and weak equivalences in model categories (e.g. they are stable by composition). Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
… categories (leanprover-community#26166) Basic consequences of the retract argument are obtained for model categories: cofibrations are exactly the morphisms that have the left lifting property with respect to trivial fibrations, etc. We deduce various properties of cofibrations, fibrations and weak equivalences in model categories (e.g. they are stable by composition). Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
hrmacbeth
pushed a commit
to szqzs/mathlib4
that referenced
this pull request
Jul 28, 2025
… categories (leanprover-community#26166) Basic consequences of the retract argument are obtained for model categories: cofibrations are exactly the morphisms that have the left lifting property with respect to trivial fibrations, etc. We deduce various properties of cofibrations, fibrations and weak equivalences in model categories (e.g. they are stable by composition). Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic consequences of the retract argument are obtained for model categories: cofibrations are exactly the morphisms that have the left lifting property with respect to trivial fibrations, etc. We deduce various properties of cofibrations, fibrations and weak equivalences in model categories (e.g. they are stable by composition).
(I am sorry if this one is a little bit long. There are too many basic properties to state.)
This PR continues the work from #20210.
Original PR: #20210