[Merged by Bors] - fix: discard linarith wrong type equalities, style#2611
Closed
[Merged by Bors] - fix: discard linarith wrong type equalities, style#2611
Conversation
digama0
commented
Mar 3, 2023
| return [← rearrangeComparison e] } | ||
| def compWithZero : Preprocessor where | ||
| name := "make comparisons with zero" | ||
| transform e := try pure [← rearrangeComparison e] catch _ => pure [] |
Member
There was a problem hiding this comment.
Isn't catching everything a bit risky? Shouldn't we only catch typeclass failures?
Contributor
There was a problem hiding this comment.
Okay, I've changed this to only catch synthesis exceptions, but it is probably clunky.
eric-wieser
reviewed
Mar 3, 2023
Comment on lines
412
to
+414
| def preprocess (pps : List GlobalBranchingPreprocessor) (g : MVarId) (l : List Expr) : | ||
| MetaM (List Branch) := | ||
| pps.foldlM (fun ls pp => do pure (← ls.mapM $ fun b => do pp.process b.1 b.2).join) [(g, l)] | ||
| pps.foldlM (fun ls pp => return (← ls.mapM fun (g, l) => do pp.process g l).join) [(g, l)] |
eric-wieser
reviewed
Mar 3, 2023
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
Mostly style fixes in linarith, but also fixes #2610 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Alex J Best <alex.j.best@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
kbuzzard
pushed a commit
that referenced
this pull request
Apr 22, 2023
kim-em
added a commit
that referenced
this pull request
May 10, 2023
Mostly style fixes in linarith, but also fixes #2610 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Alex J Best <alex.j.best@gmail.com>
kim-em
pushed a commit
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly style fixes in linarith, but also fixes #2610