Skip to content

[Merged by Bors] - chore: add ContinuousLinearEquiv.prodAssoc#26082

Closed
grunweg wants to merge 5 commits intoleanprover-community:masterfrom
grunweg:MR-cle-prodAssoc
Closed

[Merged by Bors] - chore: add ContinuousLinearEquiv.prodAssoc#26082
grunweg wants to merge 5 commits intoleanprover-community:masterfrom
grunweg:MR-cle-prodAssoc

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jun 18, 2025

This PR continues the work from #25522.

Original PR: #25522

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jun 18, 2025

Comments from Original PR #25522

This section contains 1 comment(s) from the original PR, excluding bot comments.

@github-actions (2025-06-06 06:54 UTC):

PR summary 93e9e95c5a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_prodAssoc
+ prodAssoc
+ prodAssoc_toEquiv
+ prodAssoc_toLinearEquiv

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg mentioned this pull request Jun 18, 2025
Closed
@grunweg grunweg requested a review from ocfnash June 18, 2025 12:53
@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jun 18, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 18, 2025 •
edited
Loading

PR summary 8eb1f2fefe

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_prodAssoc
+ prodAssoc
+ prodAssoc_apply
+ prodAssoc_symm_apply
+ prodAssoc_toLinearEquiv

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg mentioned this pull request Jun 19, 2025
Open
4 tasks
@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 23, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 23, 2025
ocfnash
ocfnash approved these changes Jun 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just nits!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 23, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 23, 2025
@grunweg @ocfnash
Apply suggestions from code review
20a552f 
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jun 24, 2025

Thank you for the review!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2025
@grunweg
chore: add ContinuousLinearEquiv.prodAssoc (#26082)
1dd7c68 
This PR continues the work from #25522.

Original PR: #25522
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 24, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: add ContinuousLinearEquiv.prodAssoc [Merged by Bors] - chore: add ContinuousLinearEquiv.prodAssoc Jun 24, 2025
@mathlib-bors mathlib-bors bot closed this Jun 24, 2025
@grunweg grunweg deleted the MR-cle-prodAssoc branch July 2, 2025 11:40
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 7, 2025
@grunweg @joelriou
chore: add ContinuousLinearEquiv.prodAssoc (leanprover-community#26082)
a99e40a 
This PR continues the work from leanprover-community#25522.

Original PR: leanprover-community#25522
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@grunweg @callesonne
chore: add ContinuousLinearEquiv.prodAssoc (leanprover-community#26082)
9732520 
This PR continues the work from leanprover-community#25522.

Original PR: leanprover-community#25522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocfnash ocfnash ocfnash approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grunweg @ocfnash