[Merged by Bors] - chore(RepresentationTheory/GroupCohomology): add deprecation module#25878
Closed
101damnations wants to merge 243 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(RepresentationTheory/GroupCohomology): add deprecation module#25878101damnations wants to merge 243 commits intoleanprover-community:masterfrom
101damnations wants to merge 243 commits intoleanprover-community:masterfrom
Conversation
added 30 commits
January 22, 2025 14:37
added 3 commits
June 13, 2025 22:58
PR summary 260a59832c
|
| Files | Import difference |
|---|---|
Mathlib.RepresentationTheory.GroupCohomology.Resolution (new file) |
1716 |
Mathlib.RepresentationTheory.GroupCohomology.Basic (new file) |
1717 |
Mathlib.RepresentationTheory.GroupCohomology.LowDegree (new file) |
1915 |
Mathlib.RepresentationTheory.GroupCohomology.Functoriality (new file) |
1916 |
Mathlib.RepresentationTheory.GroupCohomology.Hilbert90 (new file) |
1920 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
I can comment on the "how to deprecate" aspect: It looks like this is the case here - so can you adjust the last commit, please? |
Collaborator
Author
|
Thanks very much! I've tried to apply this. |
…to gphombasicmovedfiles
Collaborator
|
This PR/issue depends on: |
Member
|
Thanks 🎉 bors merge |
…to gphombasicmovedfiles
Contributor
|
Canceled. |
added 3 commits
June 16, 2025 15:24
…to gphombasicmovedfiles
…to gphombasicmovedfiles
…to gphombasicmovedfiles
Member
|
bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Rida-Hamadani
pushed a commit
to Rida-Hamadani/mathlib4
that referenced
this pull request
Jun 24, 2025
…eanprover-community#25878) Adds `deprecated_module`s for files moved in leanprover-community#25868.
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
…eanprover-community#25878) Adds `deprecated_module`s for files moved in leanprover-community#25868.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
deprecated_modules for files moved in #25868.