Skip to content

[Merged by Bors] - chore(Analysis/Normed/Operator/BoundedLinearMaps): centralise one variable declaration#25677

Closed
grunweg wants to merge 1 commit intomasterfrom
MR-boundedlinearmaps-centralvars
Closed

[Merged by Bors] - chore(Analysis/Normed/Operator/BoundedLinearMaps): centralise one variable declaration#25677
grunweg wants to merge 1 commit intomasterfrom
MR-boundedlinearmaps-centralvars

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jun 10, 2025

Noticed while reviewing #25562. Prefer {X : Type*} over {X} as the latter introduces a universe metavariable.
These are the only occurrences of X in that file; #25562 will add two more.


Open in Gitpod

@grunweg grunweg requested a review from YaelDillies June 10, 2025 21:06
@grunweg grunweg added the easy < 20s of review time. See the lifecycle page for guidelines. label Jun 10, 2025
@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Jun 10, 2025
@github-actions
Copy link
Copy Markdown

PR summary ad4fe0ea7e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 10, 2025
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jun 11, 2025
…iable declaration (#25677)

Noticed while reviewing #25562. Prefer `{X : Type*}` over `{X}` as the latter introduces a universe metavariable.
These are the only occurrences of `X` in that file; #25562 will add two more.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/Normed/Operator/BoundedLinearMaps): centralise one variable declaration [Merged by Bors] - chore(Analysis/Normed/Operator/BoundedLinearMaps): centralise one variable declaration Jun 11, 2025
@mathlib-bors mathlib-bors bot closed this Jun 11, 2025
@mathlib-bors mathlib-bors bot deleted the MR-boundedlinearmaps-centralvars branch June 11, 2025 01:11
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025
…iable declaration (leanprover-community#25677)

Noticed while reviewing leanprover-community#25562. Prefer `{X : Type*}` over `{X}` as the latter introduces a universe metavariable.
These are the only occurrences of `X` in that file; leanprover-community#25562 will add two more.
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025
…iable declaration (leanprover-community#25677)

Noticed while reviewing leanprover-community#25562. Prefer `{X : Type*}` over `{X}` as the latter introduces a universe metavariable.
These are the only occurrences of `X` in that file; leanprover-community#25562 will add two more.
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
…iable declaration (leanprover-community#25677)

Noticed while reviewing leanprover-community#25562. Prefer `{X : Type*}` over `{X}` as the latter introduces a universe metavariable.
These are the only occurrences of `X` in that file; leanprover-community#25562 will add two more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants