Skip to content

[Merged by Bors] - feat(GroupWithZero/WithZero): injectivity and monotonicity of WithZero.map'#25660

Closed
pechersky wants to merge 4 commits intomasterfrom
pechersky/with-zero-map-api
Closed

[Merged by Bors] - feat(GroupWithZero/WithZero): injectivity and monotonicity of WithZero.map'#25660
pechersky wants to merge 4 commits intomasterfrom
pechersky/with-zero-map-api

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

@pechersky pechersky commented Jun 10, 2025

factored out of #22420

Open in Gitpod

@pechersky pechersky requested a review from YaelDillies June 10, 2025 14:46
@pechersky pechersky added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Jun 10, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 10, 2025 •
edited
Loading

PR summary fa2a544b28

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _
+ map'_injective
+ map'_injective_iff
+ map'_mono
+ map'_strictMono
+ not_coe_le_zero
+ not_lt_zero
+ «exists»
+ «forall»

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@pechersky pechersky mentioned this pull request Jun 10, 2025
Closed
3 tasks
@YaelDillies YaelDillies changed the title feat(GroupWithZero/WithZero): injectivity and monotonicity of WithZero.map' feat(GroupWithZero/WithZero): injectivity and monotonicity of WithZero.map' Jun 10, 2025
YaelDillies
YaelDillies approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With those two golfs in: Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 10, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 10, 2025
b-mehta
b-mehta approved these changes Jun 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 11, 2025

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 11, 2025
@pechersky
Copy link
Copy Markdown
Contributor Author

pechersky commented Jun 11, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jun 11, 2025
@pechersky @YaelDillies
feat(GroupWithZero/WithZero): injectivity and monotonicity of `WithZe…
124c4b2 
…ro.map'` (#25660)

factored out of #22420




Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(GroupWithZero/WithZero): injectivity and monotonicity of WithZero.map' [Merged by Bors] - feat(GroupWithZero/WithZero): injectivity and monotonicity of WithZero.map' Jun 11, 2025
@mathlib-bors mathlib-bors bot closed this Jun 11, 2025
@mathlib-bors mathlib-bors bot deleted the pechersky/with-zero-map-api branch June 11, 2025 15:07
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025
@pechersky @YaelDillies
feat(GroupWithZero/WithZero): injectivity and monotonicity of `WithZe…
fc317c6 
…ro.map'` (leanprover-community#25660)

factored out of leanprover-community#22420




Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Jun 15, 2025
@pechersky @YaelDillies
feat(GroupWithZero/WithZero): injectivity and monotonicity of `WithZe…
804fe9b 
…ro.map'` (leanprover-community#25660)

factored out of leanprover-community#22420




Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@pechersky @YaelDillies @callesonne
feat(GroupWithZero/WithZero): injectivity and monotonicity of `WithZe…
36f4304 
…ro.map'` (leanprover-community#25660)

factored out of leanprover-community#22420




Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

@b-mehta b-mehta b-mehta approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pechersky @YaelDillies @b-mehta