[Merged by Bors] - feat: tactic congr! and improvement to convert#2566
Closed
[Merged by Bors] - feat: tactic congr! and improvement to convert#2566
congr! and improvement to convert#2566Conversation
fpvandoorn
approved these changes
Mar 2, 2023
Member
fpvandoorn
left a comment
There was a problem hiding this comment.
LGTM
It would be nice to add some tests to the test folder, especially if you think that any of the subfunctions of congr! are not yet tested in mathlib.
bors d+
|
✌️ kmill can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
|
One more remark: |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
This introduces a tactic `congr!` that is an analogue to mathlib 3's `congr'`. It is a more insistent version of `congr` that makes use of more congruence lemmas (including user congruence lemmas), `propext`, `funext`, and `Subsingleton` instances. It also has a feature to lift reflexive relations to equalities. Along with `funext`, the tactic does `intros`, allowing `congr!` to get access to function bodies; the introduced variables can be named using `rename_i` if needed. This also modifies `convert` to use `congr!` rather than `congr`, which makes it work more like the mathlib3 version of the tactic.
|
Timed out. |
Contributor
Author
|
There's nothing on the queue right now, so I guess I'll try again and hope timing out was just a fluke? bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2023
This introduces a tactic `congr!` that is an analogue to mathlib 3's `congr'`. It is a more insistent version of `congr` that makes use of more congruence lemmas (including user congruence lemmas), `propext`, `funext`, and `Subsingleton` instances. It also has a feature to lift reflexive relations to equalities. Along with `funext`, the tactic does `intros`, allowing `congr!` to get access to function bodies; the introduced variables can be named using `rename_i` if needed. This also modifies `convert` to use `congr!` rather than `congr`, which makes it work more like the mathlib3 version of the tactic.
|
Pull request successfully merged into master. Build succeeded: |
congr! and improvement to convertcongr! and improvement to convert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a tactic
congr!that is an analogue to mathlib 3'scongr'. It is a more insistent version ofcongrthat makes use of more congruence lemmas (including user congruence lemmas),propext,funext, andSubsingletoninstances. It also has a feature to lift reflexive relations to equalities. Along withfunext, the tactic doesintros, allowingcongr!to get access to function bodies; the introduced variables can be named usingrename_iif needed.This also modifies
convertto usecongr!rather thancongr, which makes it work more like the mathlib3 version of the tactic.