Skip to content

feat(Valued): Valuation.leAddSubgroup and ideal/submodule versions of ltAddSubgroup#25450

Closed
pechersky wants to merge 11 commits intomasterfrom
pechersky/valuation-ltideal
Closed

feat(Valued): Valuation.leAddSubgroup and ideal/submodule versions of ltAddSubgroup#25450
pechersky wants to merge 11 commits intomasterfrom
pechersky/valuation-ltideal

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

@pechersky pechersky commented Jun 4, 2025

Also prove that these are clopen.

Factored out of #24627

Fix capitalization spelling mistake on closedball in a lemma


Open in Gitpod

@pechersky pechersky requested a review from loefflerd June 4, 2025 18:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 4, 2025

PR summary ae61e80b6c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isClopen_leAddSubgroup
+ isClopen_leIdeal
+ isClopen_leSubmodule
+ isClopen_ltAddSubgroup
+ isClopen_ltIdeal
+ isClopen_ltSubmodule
+ isClosed_leAddSubgroup
+ isClosed_leIdeal
+ isClosed_leSubmodule
+ isClosed_ltAddSubgroup
+ isClosed_ltIdeal
+ isClosed_ltSubmodule
+ isOpen_closedBall
+ isOpen_leAddSubgroup
+ isOpen_leIdeal
+ isOpen_leSubmodule
+ isOpen_ltAddSubgroup
+ isOpen_ltIdeal
+ isOpen_ltSubmodule
+ leAddSubgroup
+ leAddSubgroup_mono
+ leAddSubgroup_zero
+ leIdeal
+ leIdeal_map_algebraMap_eq_leSubmodule_min
+ leIdeal_mono
+ leIdeal_v_le_of_mem
+ leIdeal_zero
+ leSubmodule
+ leSubmodule_comap_algebraMap_eq_leIdeal
+ leSubmodule_mono
+ leSubmodule_v_le_of_mem
+ leSubmodule_zero
+ ltAddSubgroup_le_leAddSubgroup
+ ltAddSubgroup_mono
+ ltIdeal
+ ltIdeal_le_leIdeal
+ ltIdeal_mono
+ ltIdeal_v_le_of_mem
+ ltSubmodule
+ ltSubmodule_le_leSubmodule
+ ltSubmodule_mono
+ ltSubmodule_v_le_of_mem
+ mem_leAddSubgroup_iff
+ mem_leIdeal_iff
+ mem_leSubmodule_iff
+ mem_ltAddSubgroup_iff
+ mem_ltIdeal_iff
+ mem_ltSubmodule_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@pechersky pechersky added t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-analysis Analysis (normed *, calculus) t-algebra Algebra (groups, rings, fields, etc) labels Jun 4, 2025
@pechersky pechersky requested a review from faenuccio June 4, 2025 18:29
@faenuccio
Copy link
Copy Markdown
Contributor

In #14752 we're updating the definition of Valued defining a SubgroupWithZero and the like. Do you mind putting this PR on hold (as WIP) perhaps marking that it "depends" on #14752? This won't probably be true, but at least you'll get a message from GitHub as soon as that one is merged.

@pechersky
Copy link
Copy Markdown
Contributor Author

Thanks for pointing out the interaction with the other PR, @faenuccio. How would the underlying definition of Valued affect these constructions? They're really valid over any Valuation. I can move the ideal and submodule constructions to be directly on Valuation.integer, which would decouple them even further from the Valued typeclass. Then the only things that would rely on Valued would be the clopen statements, which would remain true regardless, since you're not changing the underlying topology.

These constructions are factored out from the IsLinearTopology PR which allows for evaluation of power series over Z_p or Q_p. I'm hoping to define that to be able to state Strassman's theorem.

@faenuccio
Copy link
Copy Markdown
Contributor

Thanks for pointing out the interaction with the other PR, @faenuccio. How would the underlying definition of Valued affect these constructions? They're really valid over any Valuation. I can move the ideal and submodule constructions to be directly on Valuation.integer, which would decouple them even further from the Valued typeclass. Then the only things that would rely on Valued would be the clopen statements, which would remain true regardless, since you're not changing the underlying topology.

These constructions are factored out from the IsLinearTopology PR which allows for evaluation of power series over Z_p or Q_p. I'm hoping to define that to be able to state Strassman's theorem.

I need to split the other PR in two following a reviewer's request. As soon as I do, I'll have a clearer vision and will (hopefully be able to) answer your questions... 😅

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 5, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@pechersky
Copy link
Copy Markdown
Contributor Author

Superseded by #26829.

@pechersky pechersky closed this Jul 6, 2025
@YaelDillies YaelDillies deleted the pechersky/valuation-ltideal branch August 15, 2025 16:43
mathlib-bors bot pushed a commit that referenced this pull request Oct 22, 2025
…le versions of ltAddSubgroup (#26829)

Extracted from #25450 without changing how Valued works
mathlib-bors bot pushed a commit that referenced this pull request Oct 22, 2025
…le versions of ltAddSubgroup (#26829)

Extracted from #25450 without changing how Valued works
mathlib-bors bot pushed a commit that referenced this pull request Oct 22, 2025
…le versions of ltAddSubgroup (#26829)

Extracted from #25450 without changing how Valued works
mathlib-bors bot pushed a commit that referenced this pull request Oct 22, 2025
…le versions of ltAddSubgroup (#26829)

Extracted from #25450 without changing how Valued works
mathlib-bors bot pushed a commit that referenced this pull request Oct 22, 2025
…le versions of ltAddSubgroup (#26829)

Extracted from #25450 without changing how Valued works
mathlib-bors bot pushed a commit that referenced this pull request Oct 22, 2025
…le versions of ltAddSubgroup (#26829)

Extracted from #25450 without changing how Valued works
Jlh18 pushed a commit to Jlh18/mathlib4 that referenced this pull request Oct 24, 2025
…le versions of ltAddSubgroup (leanprover-community#26829)

Extracted from leanprover-community#25450 without changing how Valued works
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
…le versions of ltAddSubgroup (leanprover-community#26829)

Extracted from leanprover-community#25450 without changing how Valued works
FormulaRabbit81 pushed a commit to FormulaRabbit81/mathlib4 that referenced this pull request Nov 8, 2025
…le versions of ltAddSubgroup (leanprover-community#26829)

Extracted from leanprover-community#25450 without changing how Valued works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc) t-analysis Analysis (normed *, calculus) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants