feat(Valued): Valuation.leAddSubgroup and ideal/submodule versions of ltAddSubgroup#25450
feat(Valued): Valuation.leAddSubgroup and ideal/submodule versions of ltAddSubgroup#25450
Conversation
… ltAddSubgroup Also golf existing proofs
PR summary ae61e80b6cImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
Thanks for pointing out the interaction with the other PR, @faenuccio. How would the underlying definition of Valued affect these constructions? They're really valid over any Valuation. I can move the ideal and submodule constructions to be directly on Valuation.integer, which would decouple them even further from the Valued typeclass. Then the only things that would rely on Valued would be the clopen statements, which would remain true regardless, since you're not changing the underlying topology. These constructions are factored out from the IsLinearTopology PR which allows for evaluation of power series over Z_p or Q_p. I'm hoping to define that to be able to state Strassman's theorem. |
I need to split the other PR in two following a reviewer's request. As soon as I do, I'll have a clearer vision and will (hopefully be able to) answer your questions... 😅 |
doesn't require Valued
|
This pull request has conflicts, please merge |
|
Superseded by #26829. |
…le versions of ltAddSubgroup (leanprover-community#26829) Extracted from leanprover-community#25450 without changing how Valued works
…le versions of ltAddSubgroup (leanprover-community#26829) Extracted from leanprover-community#25450 without changing how Valued works
…le versions of ltAddSubgroup (leanprover-community#26829) Extracted from leanprover-community#25450 without changing how Valued works
Also prove that these are clopen.
Factored out of #24627
Fix capitalization spelling mistake on
closedballin a lemma