feat: check that the mathlib options exist#25407
Closed
Conversation
PR summary 0018ee710eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
reviewed
Jun 4, 2025
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
Contributor
Author
|
I am maintainer merging a PR that was already maintainer merged, to test the emoji system! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by adomani. |
Contributor
Author
|
This PR has been migrated to a fork-based workflow: #25687 |
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Jun 15, 2025
This PR continues the work from leanprover-community#25407. Original PR: leanprover-community#25407
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Jun 15, 2025
This PR continues the work from leanprover-community#25407. Original PR: leanprover-community#25407
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
This PR continues the work from leanprover-community#25407. Original PR: leanprover-community#25407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple check that all the options mentioned in
mathlibStandardSetexist (at least, the ones that do exist!).