Skip to content

[Merged by Bors] - feat(Algebra/Order): add Archimedean class#25144

Closed
wwylele wants to merge 18 commits intomasterfrom
wwylele-hahn-class
Closed

[Merged by Bors] - feat(Algebra/Order): add Archimedean class#25144
wwylele wants to merge 18 commits intomasterfrom
wwylele-hahn-class

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented May 24, 2025

This is the first of PRs for Hahn embedding theorem #25140


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 24, 2025

PR summary 45feb5a269

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Order.Archimedean.Class (new file) 722

Declarations diff

+ MulArchimedeanClass
+ MulArchimedeanOrder
+ ind
+ instance : IsTotal (MulArchimedeanOrder M) (· ≤ ·)
+ instance : LE (MulArchimedeanOrder M)
+ instance : LT (MulArchimedeanOrder M)
+ instance : LinearOrder (MulArchimedeanClass M) := by
+ instance : OrderTop (MulArchimedeanClass M)
+ instance : Preorder (MulArchimedeanOrder M)
+ instance [Nontrivial M] : Nontrivial (MulArchimedeanClass M)
+ le_def
+ lt_def
+ lt_of_mk_lt_mk_of_le_one
+ lt_of_mk_lt_mk_of_one_le
+ map_mabs
+ map_mk_eq
+ map_mk_le
+ min_le_mk_mul
+ mk
+ mk_antitoneOn
+ mk_div_comm
+ mk_eq_mk
+ mk_eq_mk_of_mulArchimedean
+ mk_eq_top_iff
+ mk_inv
+ mk_le_mk
+ mk_left_le_mk_mul
+ mk_lt_mk
+ mk_mabs
+ mk_monotoneOn
+ mk_mul_eq_mk_left
+ mk_mul_eq_mk_right
+ mk_one
+ mk_out
+ mk_prod
+ mk_right_le_mk_mul
+ mk_surjective
+ mulArchimedean_of_mk_eq_mk
+ of
+ of_symm_eq
+ of_val
+ one_lt_of_one_lt_of_mk_lt
+ orderHom_injective
+ orderHom_mk
+ orderHom_top
+ out
+ out_top
+ range_mk
+ val
+ val_of
+ val_symm_eq
++ orderHom

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label May 24, 2025
@wwylele wwylele force-pushed the wwylele-hahn-class branch from f169507 to 26445a4 Compare May 24, 2025 13:11
@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 24, 2025
@wwylele wwylele force-pushed the wwylele-hahn-class branch from 26445a4 to 5624204 Compare May 24, 2025 13:29
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 24, 2025
@wwylele wwylele force-pushed the wwylele-hahn-class branch from 5624204 to 1f046f1 Compare May 24, 2025 13:54
@wwylele wwylele mentioned this pull request May 25, 2025
7 tasks
@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 6, 2025
@wwylele wwylele force-pushed the wwylele-hahn-class branch from 1f046f1 to 840651f Compare June 6, 2025 22:55
@wwylele wwylele removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 6, 2025
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Jun 7, 2025

Thanks for the review! While addressing the comments, I realized the m ≠ 0 and n ≠ 0 conditions aren't necessary in the definition of Archimedean equivalence (If m satisfies the inequality, then m' = m + 1 ≠ 0 obviously also satisfies it). This brings the definition closer to the definition of Archimedean group, and I further simplified some proofs with it.

I also added the converse of archimedean_of_mk_eq_mk

@wwylele wwylele force-pushed the wwylele-hahn-class branch from 26e1642 to 39e6965 Compare June 7, 2025 13:16
@wwylele wwylele force-pushed the wwylele-hahn-class branch 2 times, most recently from 6a69689 to 60a3e25 Compare June 7, 2025 15:16
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 8, 2025
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Jun 8, 2025

Updated with the suggestion of using antisymmetrization, now no theorems uses out any more (except those with out in the statement, in case I need them in the future).

I noticed that https://leanprover-community.github.io/mathlib4_docs/Mathlib/Order/Antisymmetrization.html#instLinearOrderAntisymmetrizationLeOfDecidableLEOfDecidableLTOfIsTotal only accepts relations. While technically it can be generalized to accepting arbitrary relation, it brings in more questions, such as whether < should be derived or provided. In the end, I decided to create a type synonym to equip it with and <, and it looks good and potentially useful for other things (e.g. it can already have a orderHom on its own).

@wwylele wwylele removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 8, 2025
@wwylele wwylele force-pushed the wwylele-hahn-class branch 2 times, most recently from 3af5c97 to 3431e17 Compare June 10, 2025 01:14
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 10, 2025
@wwylele wwylele force-pushed the wwylele-hahn-class branch from a3de9ed to 7661373 Compare June 10, 2025 17:53
@YaelDillies YaelDillies added awaiting-author A reviewer has asked the author a question or requested changes. t-order Order theory labels Jun 11, 2025
@wwylele wwylele removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 11, 2025
@wwylele wwylele requested a review from YaelDillies June 11, 2025 22:48
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 12, 2025
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Jun 13, 2025

Did a small clean up following similar suggestions from #25168

@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 16, 2025
@wwylele wwylele removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 16, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 16, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jun 16, 2025
This is the first of PRs for Hahn embedding theorem #25140
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 16, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Order): add Archimedean class [Merged by Bors] - feat(Algebra/Order): add Archimedean class Jun 16, 2025
@mathlib-bors mathlib-bors bot closed this Jun 16, 2025
@mathlib-bors mathlib-bors bot deleted the wwylele-hahn-class branch June 16, 2025 12:55
Rida-Hamadani pushed a commit to Rida-Hamadani/mathlib4 that referenced this pull request Jun 24, 2025
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants