[Merged by Bors] - refactor: create a LinterSet for all mathlib syntax linters enabled b…#24924
Closed
[Merged by Bors] - refactor: create a LinterSet for all mathlib syntax linters enabled b…#24924
Conversation
PR summary 368dba55a3Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Init | 27 | 28 | +1 (+3.70%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 6421 files with changed transitive imports taking up over 270181 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
d9bf21a to
5a76c90
Compare
Vierkantor
reviewed
May 15, 2025
Vierkantor
reviewed
May 15, 2025
Vierkantor
approved these changes
May 15, 2025
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Vierkantor
reviewed
May 16, 2025
Vierkantor
approved these changes
May 16, 2025
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
LGTM otherwise, thanks! I should be doing a lot of the upcoming Lean toolchain release so I should be able merge this immediately when the feature is in. But feel free to poke me if I forget about this :)
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
grunweg
commented
May 16, 2025
Collaborator
|
This pull request has conflicts, please merge |
1 task
Contributor
Author
|
CI passes now 🎉 @Vierkantor Anything else left to do? |
Vierkantor
approved these changes
Jun 3, 2025
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
I tested to make sure that the non-default linters still fire. So I think this is good to go, thank you!
bors d+
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Thanks for the review. Let's see how this one does! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
#24924) …y default Use the new feature added in leanprover/lean4#8106. Co-authored-by: grunweg <rothgami@math.hu-berlin.de> Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
joelriou
pushed a commit
that referenced
this pull request
Jun 8, 2025
#24924) …y default Use the new feature added in leanprover/lean4#8106. Co-authored-by: grunweg <rothgami@math.hu-berlin.de> Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
TOMILO87
pushed a commit
that referenced
this pull request
Jun 8, 2025
#24924) …y default Use the new feature added in leanprover/lean4#8106. Co-authored-by: grunweg <rothgami@math.hu-berlin.de> Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
leanprover-community#24924) …y default Use the new feature added in leanprover/lean4#8106. Co-authored-by: grunweg <rothgami@math.hu-berlin.de> Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y default
Use the new feature added in leanprover/lean4#8106.
The import increase is harmless: this adds one
Leanfile toMathlib.Init, which is small and self-contained.