[Merged by Bors] - chore: Restore most of the mono attribute#2491
Closed
[Merged by Bors] - chore: Restore most of the mono attribute#2491
Conversation
mcdoll
reviewed
Feb 26, 2023
Contributor
Author
I made some other changes at these 2 places (I don't know if that's a good change or not)... |
Member
|
Oh, so the syntax is probably then |
jcommelin
reviewed
Feb 28, 2023
Member
jcommelin
left a comment
There was a problem hiding this comment.
I think you don't need to manually add the mono attribute to additive versions if you pass mono via attr := to to_additive.
@fpvandoorn can you confirm this?
|
|
||
| -- Porting note: commented out the next line since tactic `mono` does not yet exist | ||
| -- attribute [mono] sum_mono | ||
| attribute [mono] sum_mono |
Member
There was a problem hiding this comment.
I conjecture that this is not needed if you have the attr := mono on L680.
|
|
||
| -- Porting note: removed `mono` attribute, not implemented yet. | ||
| -- attribute [mono] nsmul_le_nsmul_of_le_right | ||
| attribute [mono] nsmul_le_nsmul_of_le_right |
| #align set.mul_subset_mul Set.mul_subset_mul | ||
| #align set.add_subset_add Set.add_subset_add | ||
|
|
||
| attribute [mono] add_subset_add |
Member
|
|
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
Restore most of the `mono` attribute now that #1740 is merged. I think I got all of the `mono`s.
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore most of the
monoattribute now that #1740 is merged.I think I got all of the
monos.Restore
monoso that when porting,monotactic has a better chance to just work.