Skip to content

[Merged by Bors] - feat: Equiv.functionSwap#24821

Closed
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser-patch-2
Closed

[Merged by Bors] - feat: Equiv.functionSwap#24821
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser-patch-2

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 12, 2025

PR summary a943bb5216

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.Function.swap_bijective
+ functionSwap

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-logic Logic (model theory, etc) label May 12, 2025
@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label May 12, 2025
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 12, 2025
@j-loreaux
Copy link
Copy Markdown
Contributor

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 12, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 13, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Equiv.functionSwap [Merged by Bors] - feat: Equiv.functionSwap May 13, 2025
@mathlib-bors mathlib-bors bot closed this May 13, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser-patch-2 branch May 13, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants