Skip to content

[Merged by Bors] - feat: coercing e : M ≃ₛₗ[σ] M₂ to M ≃ₛₗ[σ] M₂ does nothing#24779

Closed
YaelDillies wants to merge 1 commit intomasterfrom
semilinear_equiv_apply
Closed

[Merged by Bors] - feat: coercing e : M ≃ₛₗ[σ] M₂ to M ≃ₛₗ[σ] M₂ does nothing#24779
YaelDillies wants to merge 1 commit intomasterfrom
semilinear_equiv_apply

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented May 11, 2025

It's a big issue that this coercion even exists, but it is difficult to remove at the moment, cf #21031.

From Toric


Open in Gitpod

It's a big issue that this coercion even exists, but it is difficult to remove at the moment, cf #21031.
@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) toric Part of the ongoing formalisation of toric varieties labels May 11, 2025
@github-actions
Copy link
Copy Markdown

PR summary b9fa409969

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.SemilinearEquivClass.semilinearEquiv_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label May 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 11, 2025
It's a big issue that this coercion even exists, but it is difficult to remove at the moment, cf #21031.

From Toric
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: coercing e : M ≃ₛₗ[σ] M₂ to M ≃ₛₗ[σ] M₂ does nothing [Merged by Bors] - feat: coercing e : M ≃ₛₗ[σ] M₂ to M ≃ₛₗ[σ] M₂ does nothing May 11, 2025
@mathlib-bors mathlib-bors bot closed this May 11, 2025
@mathlib-bors mathlib-bors bot deleted the semilinear_equiv_apply branch May 11, 2025 16:37
tannerduve pushed a commit that referenced this pull request May 13, 2025
It's a big issue that this coercion even exists, but it is difficult to remove at the moment, cf #21031.

From Toric
bwehlin pushed a commit to bwehlin/mathlib4 that referenced this pull request May 31, 2025
…rover-community#24779)

It's a big issue that this coercion even exists, but it is difficult to remove at the moment, cf leanprover-community#21031.

From Toric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) toric Part of the ongoing formalisation of toric varieties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants