Skip to content

feat(CategoryTheory): abstract argument for the stability under transfinite compositions#24777

Closed
joelriou wants to merge 17 commits intomasterfrom
jriou-is-stable-under-transfinite-composition-argument
Closed

feat(CategoryTheory): abstract argument for the stability under transfinite compositions#24777
joelriou wants to merge 17 commits intomasterfrom
jriou-is-stable-under-transfinite-composition-argument

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented May 11, 2025

If a class of morphisms is multiplicative, respects isomorphisms and is stable under filtered colimits, then it is stable under transfinite compositions.
(This simplifies the proof in the case of monomorphisms in Grothendieck abelian categories, for isomorphisms, and in #23282, we shall apply this to monomorphisms in Type.)


Open in Gitpod

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels May 11, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label May 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 11, 2025

PR summary d9d3b4ca93

Import changes exceeding 2%

% File
+2.55% Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition 744 763 +19 (+2.55%)
Mathlib.CategoryTheory.MorphismProperty.Limits 656 658 +2 (+0.30%)
Mathlib.CategoryTheory.Abelian.GrothendieckCategory.Monomorphisms 1046 1045 -1 (-0.10%)
Mathlib.CategoryTheory.Abelian.GrothendieckCategory.EnoughInjectives 1163 1162 -1 (-0.09%)
Import changes for all files
Files Import difference
6 files Mathlib.CategoryTheory.Abelian.FreydMitchell Mathlib.CategoryTheory.Abelian.GrothendieckCategory.Coseparator Mathlib.CategoryTheory.Abelian.GrothendieckCategory.EnoughInjectives Mathlib.CategoryTheory.Abelian.GrothendieckCategory.ModuleEmbedding.GabrielPopescu Mathlib.CategoryTheory.Abelian.GrothendieckCategory.ModuleEmbedding.Opposite Mathlib.CategoryTheory.Abelian.GrothendieckCategory.Monomorphisms
-1
53 files Mathlib.AlgebraicGeometry.AffineScheme Mathlib.AlgebraicGeometry.AffineSpace Mathlib.AlgebraicGeometry.Cover.MorphismProperty Mathlib.AlgebraicGeometry.Cover.Open Mathlib.AlgebraicGeometry.Cover.Sigma Mathlib.AlgebraicGeometry.Fiber Mathlib.AlgebraicGeometry.FunctionField Mathlib.AlgebraicGeometry.GammaSpecAdjunction Mathlib.AlgebraicGeometry.GluingOneHypercover Mathlib.AlgebraicGeometry.Gluing Mathlib.AlgebraicGeometry.IdealSheaf.Basic Mathlib.AlgebraicGeometry.IdealSheaf.Functorial Mathlib.AlgebraicGeometry.IdealSheaf.Subscheme Mathlib.AlgebraicGeometry.IdealSheaf Mathlib.AlgebraicGeometry.Limits Mathlib.AlgebraicGeometry.Morphisms.AffineAnd Mathlib.AlgebraicGeometry.Morphisms.Affine Mathlib.AlgebraicGeometry.Morphisms.Basic Mathlib.AlgebraicGeometry.Morphisms.ClosedImmersion Mathlib.AlgebraicGeometry.Morphisms.Constructors Mathlib.AlgebraicGeometry.Morphisms.FinitePresentation Mathlib.AlgebraicGeometry.Morphisms.FiniteType Mathlib.AlgebraicGeometry.Morphisms.Finite Mathlib.AlgebraicGeometry.Morphisms.Flat Mathlib.AlgebraicGeometry.Morphisms.Integral Mathlib.AlgebraicGeometry.Morphisms.IsIso Mathlib.AlgebraicGeometry.Morphisms.OpenImmersion Mathlib.AlgebraicGeometry.Morphisms.Preimmersion Mathlib.AlgebraicGeometry.Morphisms.QuasiCompact Mathlib.AlgebraicGeometry.Morphisms.QuasiSeparated Mathlib.AlgebraicGeometry.Morphisms.RingHomProperties Mathlib.AlgebraicGeometry.Morphisms.Smooth Mathlib.AlgebraicGeometry.Morphisms.SurjectiveOnStalks Mathlib.AlgebraicGeometry.Morphisms.UnderlyingMap Mathlib.AlgebraicGeometry.Morphisms.UniversallyClosed Mathlib.AlgebraicGeometry.Morphisms.UniversallyInjective Mathlib.AlgebraicGeometry.Morphisms.UniversallyOpen Mathlib.AlgebraicGeometry.Noetherian Mathlib.AlgebraicGeometry.OpenImmersion Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Basic Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Scheme Mathlib.AlgebraicGeometry.Properties Mathlib.AlgebraicGeometry.PullbackCarrier Mathlib.AlgebraicGeometry.Pullbacks Mathlib.AlgebraicGeometry.ResidueField Mathlib.AlgebraicGeometry.Restrict Mathlib.AlgebraicGeometry.Sites.BigZariski Mathlib.AlgebraicGeometry.Sites.MorphismProperty Mathlib.AlgebraicGeometry.Sites.Representability Mathlib.AlgebraicGeometry.Sites.SmallAffineZariski Mathlib.AlgebraicGeometry.SpreadingOut Mathlib.AlgebraicGeometry.Stalk Mathlib.CategoryTheory.Limits.MorphismProperty
1
24 files Mathlib.Algebra.Homology.Square Mathlib.AlgebraicTopology.Quasicategory.Basic Mathlib.AlgebraicTopology.Quasicategory.Nerve Mathlib.AlgebraicTopology.Quasicategory.StrictSegal Mathlib.AlgebraicTopology.RelativeCellComplex.AttachCells Mathlib.AlgebraicTopology.SimplicialSet.CategoryWithFibrations Mathlib.AlgebraicTopology.SimplicialSet.KanComplex Mathlib.CategoryTheory.Abelian.Monomorphisms Mathlib.CategoryTheory.Limits.Preserves.Shapes.Square Mathlib.CategoryTheory.Limits.Shapes.Pullback.Square Mathlib.CategoryTheory.Localization.FiniteProducts Mathlib.CategoryTheory.MorphismProperty.Descent Mathlib.CategoryTheory.MorphismProperty.LiftingProperty Mathlib.CategoryTheory.MorphismProperty.Limits Mathlib.CategoryTheory.MorphismProperty.OverAdjunction Mathlib.CategoryTheory.MorphismProperty.Representable Mathlib.CategoryTheory.MorphismProperty.RetractArgument Mathlib.CategoryTheory.MorphismProperty.WeakFactorizationSystem Mathlib.CategoryTheory.Preadditive.Injective.LiftingProperties Mathlib.CategoryTheory.Preadditive.Projective.LiftingProperties Mathlib.CategoryTheory.Sites.MayerVietorisSquare Mathlib.CategoryTheory.Sites.MorphismProperty Mathlib.CategoryTheory.SmallObject.Construction Mathlib.Topology.Sheaves.MayerVietoris
2
Mathlib.CategoryTheory.MorphismProperty.TransfiniteComposition Mathlib.CategoryTheory.SmallObject.TransfiniteIteration 19

Declarations diff

+ IsStableUnderFilteredColimits
+ IsStableUnderTransfiniteCompositionOfShape.of_isStableUnderColimitsOfShape
+ colimitsOfShape.of_isColimit
+ instance (j : J) : IsIso (h.incl.app j) := (h.ici j).isIso
+ instance : IsStableUnderFilteredColimits.{w, w'} (isomorphisms C)
+ instance [HasFilteredColimitsOfSize.{v', u'} C] [AB5OfSize.{v', u'} C] :
+ instance {C : Type u} [Category.{v} C] [Abelian C] [IsGrothendieckAbelian.{w} C] :
+ instance {i j : J} (f : i ⟶ j) : IsIso (h.F.map f) := ((h.iic j).ici (⟨i, leOfHom f⟩)).isIso
+ mem
+ mem_map_bot_le
++ instance [W.IsMultiplicative] [W.RespectsIso]
- instance (j : J) : IsIso (h.incl.app j)
- instance : (isomorphisms C).IsStableUnderTransfiniteComposition
- instance : IsStableUnderTransfiniteComposition.{w} (monomorphisms C)
- instance {j : J} (g : ⊥ ⟶ j) : IsIso (h.F.map g) := by
- instance {j j' : J} (f : j ⟶ j') : IsIso (h.F.map f)
- map_bot_le
- mono
- mono_map

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 11, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 13, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 13, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 13, 2025
@callesonne callesonne self-requested a review May 13, 2025 20:16
@joelriou joelriou removed the WIP Work in progress label May 17, 2025
Copy link
Copy Markdown
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!!

@callesonne callesonne added the awaiting-author A reviewer has asked the author a question or requested changes. label May 29, 2025
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 31, 2025
Copy link
Copy Markdown
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@callesonne callesonne added the awaiting-author A reviewer has asked the author a question or requested changes. label May 31, 2025
Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 31, 2025
joelriou and others added 4 commits June 1, 2025 16:36
@callesonne
Copy link
Copy Markdown
Collaborator

@erdOne do you want to have a look and/or maintainer merge? :)

@joelriou
Copy link
Copy Markdown
Contributor Author

This PR has been migrated to a fork-based workflow: #26030

@joelriou joelriou closed this Jun 17, 2025
@YaelDillies YaelDillies deleted the jriou-is-stable-under-transfinite-composition-argument branch August 18, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports migrated-to-fork t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants