Skip to content

[Merged by Bors] - chore(CategoryTheory): make MorphismProperty.IsStableUnderColimitsOfShape a class#24773

Closed
joelriou wants to merge 3 commits intomasterfrom
jriou-is-stable-under-colimits-of-shape-class
Closed

[Merged by Bors] - chore(CategoryTheory): make MorphismProperty.IsStableUnderColimitsOfShape a class#24773
joelriou wants to merge 3 commits intomasterfrom
jriou-is-stable-under-colimits-of-shape-class

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented May 11, 2025

Open in Gitpod

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels May 11, 2025
@joelriou joelriou mentioned this pull request May 11, 2025
Closed
2 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 11, 2025 •
edited
Loading

PR summary 6dca8acf2f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ colimMap
+ colimitsOfShape.mk'
+ colimitsOfShape_le
+ limMap
+ limitsOfShape.mk'
+ limitsOfShape_le
- isStableUnderCoproductsOfShape_of_isStableUnderCoproducts

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou joelriou mentioned this pull request May 11, 2025
Closed
1 task
@joelriou joelriou removed the WIP Work in progress label May 11, 2025
callesonne
callesonne reviewed May 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@callesonne callesonne added the awaiting-author A reviewer has asked the author a question or requested changes. label May 12, 2025
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 12, 2025
callesonne
callesonne approved these changes May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, LGTM! @erdOne could you maintainer merge when you have the time?

erdOne
erdOne approved these changes May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 13, 2025

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 13, 2025
jcommelin
jcommelin reviewed May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 13, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 13, 2025
@joelriou
chore(CategoryTheory): make MorphismProperty.IsStableUnderColimitsOfS…
f916686 
…hape a class (#24773)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 13, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory): make MorphismProperty.IsStableUnderColimitsOfShape a class [Merged by Bors] - chore(CategoryTheory): make MorphismProperty.IsStableUnderColimitsOfShape a class May 13, 2025
@mathlib-bors mathlib-bors bot closed this May 13, 2025
@mathlib-bors mathlib-bors bot deleted the jriou-is-stable-under-colimits-of-shape-class branch May 13, 2025 14:58
tannerduve pushed a commit that referenced this pull request May 13, 2025
@joelriou @tannerduve
chore(CategoryTheory): make MorphismProperty.IsStableUnderColimitsOfS…
90fe37c 
…hape a class (#24773)
jano-wol pushed a commit that referenced this pull request May 16, 2025
@joelriou @jano-wol
chore(CategoryTheory): make MorphismProperty.IsStableUnderColimitsOfS…
54faef4 
…hape a class (#24773)
bwehlin pushed a commit to bwehlin/mathlib4 that referenced this pull request May 31, 2025
@joelriou
chore(CategoryTheory): make MorphismProperty.IsStableUnderColimitsOfS…
b351641 
…hape a class (leanprover-community#24773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@erdOne erdOne erdOne approved these changes

+1 more reviewer

@callesonne callesonne callesonne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelriou @jcommelin @callesonne @erdOne