Skip to content

[Merged by Bors] - fix(Order): remove leftover OrderDual from Set.isWF_iff_no_descending_seq#24776

Closed
wwylele wants to merge 1 commit intomasterfrom
wwylele-remove-dual
Closed

[Merged by Bors] - fix(Order): remove leftover OrderDual from Set.isWF_iff_no_descending_seq#24776
wwylele wants to merge 1 commit intomasterfrom
wwylele-remove-dual

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented May 11, 2025

@wwylele wwylele requested review from YaelDillies and urkud May 11, 2025 12:24
@github-actions
Copy link
Copy Markdown

PR summary 8fced728dd

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-order Order theory label May 11, 2025
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 11, 2025
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 11, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 11, 2025

Build failed:

@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented May 11, 2025

Eh... the merge failed at https://github.com/leanprover-community/mathlib4/actions/runs/14956597582/job/42013117936 because

Error: No space left on device : '/home/lean/actions-runner/_work/_actions/actions/setup-python/a26af69be951a213d495a4c3e4e4022e16d87065/dist/cache-save'

I clicked re-run and it succeeded, but it doesn't seem to restart the merge attempt

@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented May 11, 2025

Not sure if I have permission to re-run
bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 11, 2025

🔒 Permission denied

Existing reviewers: click here to make wwylele a reviewer

@wwylele wwylele requested a review from b-mehta May 11, 2025 15:32
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented May 11, 2025

@b-mehta could you help restarting the bot?

@b-mehta
Copy link
Copy Markdown
Contributor

b-mehta commented May 11, 2025

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Order): remove leftover OrderDual from Set.isWF_iff_no_descending_seq [Merged by Bors] - fix(Order): remove leftover OrderDual from Set.isWF_iff_no_descending_seq May 11, 2025
@mathlib-bors mathlib-bors bot closed this May 11, 2025
@mathlib-bors mathlib-bors bot deleted the wwylele-remove-dual branch May 11, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants