Skip to content

[Merged by Bors] - feat: add Polynomial.div_C and C_div#24751

Closed
kbuzzard wants to merge 4 commits intomasterfrom
kbuzzard-C_div
Closed

[Merged by Bors] - feat: add Polynomial.div_C and C_div#24751
kbuzzard wants to merge 4 commits intomasterfrom
kbuzzard-C_div

Conversation

@kbuzzard
Copy link
Copy Markdown
Member

@kbuzzard kbuzzard commented May 10, 2025 •
edited by eric-wieser
Loading

Zulip thread: #maths > How can I get 1/2*2=1 in Q[X?] @ 💬

Co-authored-by: Eric Wieser wieser.eric@gmail.com

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 10, 2025 •
edited
Loading

PR summary 484fa0b325

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label May 10, 2025
@erdOne
Copy link
Copy Markdown
Member

erdOne commented May 10, 2025

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 10, 2025

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 10, 2025
@eric-wieser
Copy link
Copy Markdown
Member

eric-wieser commented May 10, 2025

bors merge

Thanks!

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 10, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 10, 2025
@kbuzzard
feat: add Polynomial.div_C and C_div (#24751)
1096f8b 
Zulip thread: [#maths > How can I get 1/2&#42;2=1 in Q&#91;X?&#93; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/How.20can.20I.20get.201.2F2*2.3D1.20in.20Q.5BX.3F.5D/near/517280660)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 10, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add Polynomial.div_C and C_div [Merged by Bors] - feat: add Polynomial.div_C and C_div May 10, 2025
@mathlib-bors mathlib-bors bot closed this May 10, 2025
@mathlib-bors mathlib-bors bot deleted the kbuzzard-C_div branch May 10, 2025 22:06
tannerduve pushed a commit that referenced this pull request May 13, 2025
@kbuzzard @tannerduve
feat: add Polynomial.div_C and C_div (#24751)
da78c11 
Zulip thread: [#maths > How can I get 1/2&#42;2=1 in Q&#91;X?&#93; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/How.20can.20I.20get.201.2F2*2.3D1.20in.20Q.5BX.3F.5D/near/517280660)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bwehlin pushed a commit to bwehlin/mathlib4 that referenced this pull request May 31, 2025
@kbuzzard
feat: add Polynomial.div_C and C_div (leanprover-community#24751)
77e9040 
Zulip thread: [#maths > How can I get 1/2&leanprover-community#42;2=1 in Q&leanprover-community#91;X?&leanprover-community#93; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/How.20can.20I.20get.201.2F2*2.3D1.20in.20Q.5BX.3F.5D/near/517280660)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kbuzzard @erdOne @eric-wieser