[Merged by Bors] - feat: port Data.QPF.Multivariate.Constructions.Cofix#2444
[Merged by Bors] - feat: port Data.QPF.Multivariate.Constructions.Cofix#2444alexkeizer wants to merge 20 commits intomasterfrom
Conversation
alexkeizer
commented
Feb 22, 2023
|
Everything is ported, except for a bisimulation tactic that is also defined in this file. I'm not really sure how to deal with that, I don't really know how to read the Lean 3 tactic code, so help would be appreciated. |
93ec198 to
15fbc40
Compare
|
Now needs help with a universe issue: |
It seems something beyond just an universe issue. It's trying to apply EDIT: Yes, the universe issue is resolved by giving explicit universes, but that just reveals more issues with the proof itself. |
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
0c8652e to
40186be
Compare
|
@alexkeizer @Ruben-VandeVelde |
|
@Komyyy Thanks for picking this up! I'll try having a look at the tactic, but I'm having a bit of trouble to parse what exactly is going on. Since you ported it, I assume you have more of a clue, so if you could write some documentation explaining what the tactic does, I would really appreciate it |
|
@alexkeizer What
|
|
The tactic is fine. It's also only ever used in this file, which is a leaf anyway... bors d+ |
|
✌️ alexkeizer can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thanks 🎉 bors merge |
Co-authored-by: Alex Keizer <alex@keizer.dev> Co-authored-by: Komyyy <pol_tta@outlook.jp>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Co-authored-by: Alex Keizer <alex@keizer.dev> Co-authored-by: Komyyy <pol_tta@outlook.jp>
Co-authored-by: Alex Keizer <alex@keizer.dev> Co-authored-by: Komyyy <pol_tta@outlook.jp>