Skip to content

[Merged by Bors] - chore(Data/Finsupp/MonomialOrder/DegLex): dedup instance#24046

Closed
plp127 wants to merge 1 commit intomasterfrom
aliu/deglex_inst
Closed

[Merged by Bors] - chore(Data/Finsupp/MonomialOrder/DegLex): dedup instance#24046
plp127 wants to merge 1 commit intomasterfrom
aliu/deglex_inst

Conversation

@plp127
Copy link
Copy Markdown
Contributor

@plp127 plp127 commented Apr 14, 2025 •
edited
Loading

Split from #23976

The remaining instance is at

mathlib4/Mathlib/Data/Finsupp/MonomialOrder/DegLex.lean

Lines 125 to 129 in 03e9f15

/-- The linear order on `Finsupp`s obtained by the homogeneous lexicographic ordering. -/
instance : LinearOrder (DegLex (α →₀ ℕ)) :=
LinearOrder.lift'
(fun (f : DegLex (α →₀ ℕ)) ↦ toLex ((ofDegLex f).degree, toLex (ofDegLex f)))
(fun f g ↦ by simp)

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2025

PR summary 03e9f15f2a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- instance : LinearOrder (DegLex (α →₀ ℕ))

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Apr 14, 2025
@plp127 plp127 mentioned this pull request Apr 14, 2025
Closed
2 tasks
eric-wieser
eric-wieser approved these changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Apr 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Apr 14, 2025
@plp127
chore(Data/Finsupp/MonomialOrder/DegLex): dedup instance (#24046)
2d00056 
Split from #23976

The remaining instance is at https://github.com/leanprover-community/mathlib4/blob/03e9f15f2acafae1d9d3b7e0674ba87ae3cd499c/Mathlib/Data/Finsupp/MonomialOrder/DegLex.lean#L125-L129
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Finsupp/MonomialOrder/DegLex): dedup instance [Merged by Bors] - chore(Data/Finsupp/MonomialOrder/DegLex): dedup instance Apr 14, 2025
@mathlib-bors mathlib-bors bot closed this Apr 14, 2025
@mathlib-bors mathlib-bors bot deleted the aliu/deglex_inst branch April 14, 2025 20:44
tannerduve pushed a commit that referenced this pull request May 13, 2025
@plp127 @tannerduve
chore(Data/Finsupp/MonomialOrder/DegLex): dedup instance (#24046)
a58c2cc 
Split from #23976

The remaining instance is at https://github.com/leanprover-community/mathlib4/blob/03e9f15f2acafae1d9d3b7e0674ba87ae3cd499c/Mathlib/Data/Finsupp/MonomialOrder/DegLex.lean#L125-L129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@plp127 @eric-wieser