[Merged by Bors] - chore(Surreal): dedup instance#23985
Closed
[Merged by Bors] - chore(Surreal): dedup instance#23985
Conversation
PR summary 461b2e79ddImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
2 tasks
Member
|
bors d+ I tweaked the description with some archaeology. |
Contributor
|
✌️ plp127 can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
|
bors merge I'll assume you were happy with the description change. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2025
Deduplicates the instance `LinearOrder Surreal`, which was defined in both `Surreal/Basic` and `Surreal/Multiplication`. The duplicate originated in #14044. The surviving instance is at https://github.com/leanprover-community/mathlib4/blob/461b2e79dd4c923f26e435f770faeaf87208d0d9/Mathlib/SetTheory/Surreal/Basic.lean#L368-L373
Contributor
|
Pull request successfully merged into master. Build succeeded: |
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
Deduplicates the instance `LinearOrder Surreal`, which was defined in both `Surreal/Basic` and `Surreal/Multiplication`. The duplicate originated in #14044. The surviving instance is at https://github.com/leanprover-community/mathlib4/blob/461b2e79dd4c923f26e435f770faeaf87208d0d9/Mathlib/SetTheory/Surreal/Basic.lean#L368-L373
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicates the instance
LinearOrder Surreal, which was defined in bothSurreal/BasicandSurreal/Multiplication.The duplicate originated in #14044.
The surviving instance is at
mathlib4/Mathlib/SetTheory/Surreal/Basic.lean
Lines 368 to 373 in 461b2e7