Skip to content

feat: ContinuousLinearEquiv.{prodUnique,uniqueProd}#23971

Closed
grunweg wants to merge 3 commits intomasterfrom
MR-linearequiv-produnique
Closed

feat: ContinuousLinearEquiv.{prodUnique,uniqueProd}#23971
grunweg wants to merge 3 commits intomasterfrom
MR-linearequiv-produnique

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Apr 12, 2025 •
edited
Loading

which are LinearEquiv.{prodUnique,uniqueProd} as a continuous linear equivalence.

Discovered when working on slice models for defining submanifolds (#24550), one step towards defining smooth submanifolds.

Open in Gitpod

@grunweg grunweg force-pushed the MR-linearequiv-produnique branch from 91ec070 to b180365 Compare April 12, 2025 12:58
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2025 •
edited
Loading

PR summary 50e49dc2e9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ prodUnique_apply
+ prodUnique_symm_apply
+ prodUnique_toEquiv
+ uniqueProd_apply
+ uniqueProd_symm_apply
+ uniqueProd_toEquiv
++ coe_prodUnique
++ coe_uniqueProd
++- prodUnique
++- uniqueProd

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 12, 2025
Ruben-VandeVelde
Ruben-VandeVelde reviewed Apr 17, 2025
View reviewed changes
@b-mehta b-mehta added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 17, 2025
@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 18, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 18, 2025

Let me cross-reference #9105 (a stale delegated PR adding the LinearEquiv version via AddEquiv) and this zulip thread I started about comparing these approaches.

@j-loreaux
Copy link
Copy Markdown
Contributor

j-loreaux commented Apr 19, 2025

Please go with the AddEquiv approach mentioned by Eric in order to keep the APIs in sync. I think it's fine if you just copy the relevant bits from #9105 here (to avoid dealing with merge conflicts in that PR) and close that one when you have done so.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 19, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 22, 2025

Indeed! Let's land #24168 first, and see if anything remains to be done.

@grunweg grunweg changed the title feat: LinearEquiv.prodUnique feat: ContinuousLinearEquiv.prodUnique Apr 29, 2025
@grunweg grunweg added WIP Work in progress blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Apr 29, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Apr 29, 2025
@grunweg grunweg force-pushed the MR-linearequiv-produnique branch from 43f6a7f to 93bfea4 Compare May 6, 2025 15:50
@grunweg grunweg removed the WIP Work in progress label May 6, 2025
@grunweg grunweg changed the title feat: ContinuousLinearEquiv.prodUnique feat: ContinuousLinearEquiv.{prodUnique,uniqueProd} May 6, 2025
@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label May 7, 2025
@grunweg grunweg force-pushed the MR-linearequiv-produnique branch from 93bfea4 to 46e4ade Compare June 6, 2025 03:16
@grunweg grunweg mentioned this pull request Jun 6, 2025
Closed
4 tasks
@grunweg grunweg force-pushed the MR-linearequiv-produnique branch from 46e4ade to 2199b5e Compare June 6, 2025 06:34
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 6, 2025
@grunweg grunweg mentioned this pull request Jun 6, 2025
Closed
@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 6, 2025
@grunweg grunweg requested a review from Ruben-VandeVelde June 6, 2025 07:23
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 6, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Jun 6, 2025

This PR/issue depends on:

@grunweg grunweg force-pushed the MR-linearequiv-produnique branch from 15af813 to 76b47da Compare June 6, 2025 09:38
@grunweg grunweg force-pushed the MR-linearequiv-produnique branch from 34b16c2 to d16f5e3 Compare June 14, 2025 18:08
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jun 14, 2025

CI failed with an error not related to this PR, so I merged master... except that I rebased and force-pushed. Sorry if you have to re-review everything now!

@grunweg grunweg mentioned this pull request Jun 18, 2025
Closed
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jun 18, 2025

This PR has been migrated to a fork-based workflow: #26083

@grunweg grunweg closed this Jun 18, 2025
@grunweg grunweg mentioned this pull request Jun 18, 2025
Open
4 tasks
@grunweg grunweg deleted the MR-linearequiv-produnique branch June 18, 2025 17:59
mathlib-bors bot pushed a commit that referenced this pull request Jun 19, 2025
@grunweg
feat: ContinuousLinearEquiv.{prodUnique,uniqueProd} (#26083)
4516ade 
which are `LinearEquiv.{prodUnique,uniqueProd}` as a continuous linear equivalence.

Discovered when working on slice models for defining submanifolds (#24550), one step towards defining smooth submanifolds.

This PR continues the work from #23971.
Rida-Hamadani pushed a commit to Rida-Hamadani/mathlib4 that referenced this pull request Jun 24, 2025
@grunweg @Rida-Hamadani
feat: ContinuousLinearEquiv.{prodUnique,uniqueProd} (leanprover-commu…
6f609d6 
…nity#26083)

which are `LinearEquiv.{prodUnique,uniqueProd}` as a continuous linear equivalence.

Discovered when working on slice models for defining submanifolds (leanprover-community#24550), one step towards defining smooth submanifolds.

This PR continues the work from leanprover-community#23971.
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 7, 2025
@grunweg @joelriou
feat: ContinuousLinearEquiv.{prodUnique,uniqueProd} (leanprover-commu…
0b0e5b6 
…nity#26083)

which are `LinearEquiv.{prodUnique,uniqueProd}` as a continuous linear equivalence.

Discovered when working on slice models for defining submanifolds (leanprover-community#24550), one step towards defining smooth submanifolds.

This PR continues the work from leanprover-community#23971.
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
@grunweg @callesonne
feat: ContinuousLinearEquiv.{prodUnique,uniqueProd} (leanprover-commu…
53ce4b6 
…nity#26083)

which are `LinearEquiv.{prodUnique,uniqueProd}` as a continuous linear equivalence.

Discovered when working on slice models for defining submanifolds (leanprover-community#24550), one step towards defining smooth submanifolds.

This PR continues the work from leanprover-community#23971.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Awaiting requested review from Ruben-VandeVelde

Assignees

No one assigned

Labels

migrated-to-fork t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grunweg @j-loreaux @mathlib4-dependent-issues-bot @Ruben-VandeVelde @b-mehta